Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tre: 0.8.0 -> 0.9.0 #365785

Merged
merged 1 commit into from
Jan 24, 2025
Merged

tre: 0.8.0 -> 0.9.0 #365785

merged 1 commit into from
Jan 24, 2025

Conversation

TheRealKeto
Copy link
Contributor

@TheRealKeto TheRealKeto commented Dec 17, 2024

Description

Update tre to its latest released version, 0.9.0. This change dictates a new upstream, per this blog post by the author.

On macOS, CoreFoundation and libiconv is needed when linking, but the way it's specified might not be proper. Let me know :)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

pkgs/by-name/tr/tre/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/tr/tre/package.nix Outdated Show resolved Hide resolved
Copy link
Member

@FliegendeWurst FliegendeWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Some suggestions to follow best practices.

pkgs/by-name/tr/tre/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/tr/tre/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/tr/tre/package.nix Outdated Show resolved Hide resolved
@FliegendeWurst FliegendeWurst merged commit a56b995 into NixOS:master Jan 24, 2025
24 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants