fedistar: init at 1.11.0 #366043
Open
fedistar: init at 1.11.0 #366043
+110
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
8.has: package (new)
gepbird
reviewed
Jan 15, 2025
gepbird
suggested changes
Jan 20, 2025
pkgs/by-name/fe/fedistar/package.nix
Outdated
| inherit version src; | ||
| pnpmDeps = pnpm.fetchDeps { | ||
| inherit pname version src; | ||
| hash = "sha256-RqTAb01W8/qcQonh44bT7zeeJEuLekfZW66mfT2vYYw="; |
There was a problem hiding this comment.
See #366043 (comment) (in case you didn't see the resolved thread)
Suggested change
| hash = "sha256-RqTAb01W8/qcQonh44bT7zeeJEuLekfZW66mfT2vYYw="; | |
| hash = "sha256-oYTF34LkHLHzYyIy70doFT0ynlCDw1Mku+9dVMgNBgY="; |
There was a problem hiding this comment.
There might be something non-deterministic about pnpm_10, since it gives me different hashes almost every time... I'll downgrade to pnpm_9 just in case this helps.
There was a problem hiding this comment.
(to reproduce, build the frontend, update the hash, go a garbage collection, and do it again. Different hash)
pkgs/by-name/fe/fedistar/package.nix
Outdated
| homepage = "https://fedistar.net/"; | ||
| mainProgram = "fedistar"; | ||
| license = lib.licenses.gpl3Only; | ||
| maintainers = [ lib.maintainers.noodlez1232 ]; |
There was a problem hiding this comment.
Nit: easier to add new maintainers later
Suggested change
| maintainers = [ lib.maintainers.noodlez1232 ]; | |
| maintainers = with lib.maintainers; [ | |
| oodlez1232 | |
| ]; |
It's worth noting that if they ever decide to add tray icons to the program, it will most likely suffer the same fate as cinny-desktop, where it will not be supported (see NixOS#357482)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's worth noting that if they ever decide to add tray icons to the program, it will most likely suffer the same fate as cinny-desktop, where it will not be supported (see #357482)
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.