Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: 3.31.3 -> 3.31.5 #372891

Open
wants to merge 1 commit into
base: staging
Choose a base branch
from
Open

cmake: 3.31.3 -> 3.31.5 #372891

wants to merge 1 commit into from

Conversation

MisileLab
Copy link
Contributor

@MisileLab MisileLab commented Jan 11, 2025

https://cmake.org/cmake/help/latest/release/3.31.html
https://gitlab.kitware.com/cmake/cmake/-/compare/v3.31.3...v3.31.5

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@paparodeo
Copy link
Contributor

paparodeo commented Jan 11, 2025

this needs to target staging

@MisileLab
Copy link
Contributor Author

this needs to target staging

I think it can target staging-next because it's minor update and changelog says no changes to documented features or interfaces.

@paparodeo
Copy link
Contributor

paparodeo commented Jan 11, 2025

this needs to target staging

I think it can target staging-next because it's minor update and changelog says no changes to documented features or interfaces.

that is not sufficient. it will cause too many rebuilds. the staging-next cycle is nearing the end and this will cause a darwin stdenv rebuild and thus require another week of building just due to this change.

unless there are special circumstances, if a change can go into master it can go into staging-next otherwise it needs to target staging.

@MisileLab
Copy link
Contributor Author

this needs to target staging

I think it can target staging-next because it's minor update and changelog says no changes to documented features or interfaces.

that is not sufficient. it will cause too many rebuilds. the staging-next cycle is nearing the end and this will cause a darwin stdenv rebuild and thus require another week of building just due to this change.

unless there are special circumstances, if a change can go into master it can go into staging-next otherwise it needs to target staging.

okay, I'll change targeted branch to staging.

@MisileLab MisileLab marked this pull request as draft January 11, 2025 11:08
@MisileLab MisileLab changed the base branch from staging-next to staging January 11, 2025 11:12
@MisileLab MisileLab marked this pull request as ready for review January 11, 2025 11:13
Copy link
Contributor

@paparodeo paparodeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nix-owners nix-owners bot requested review from LnL7 and ttuegel January 11, 2025 11:32
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 11, 2025
@MisileLab MisileLab marked this pull request as draft January 24, 2025 04:35
@MisileLab MisileLab changed the title cmake: 3.31.3 -> 3.31.4 cmake: 3.31.3 -> 3.31.5 Jan 24, 2025
Signed-off-by: misilelaboratory <[email protected]>
@MisileLab MisileLab marked this pull request as ready for review January 24, 2025 13:33
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants