-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmake: 3.31.3 -> 3.31.5 #372891
base: staging
Are you sure you want to change the base?
cmake: 3.31.3 -> 3.31.5 #372891
Conversation
this needs to target staging |
I think it can target staging-next because it's minor update and changelog says no changes to documented features or interfaces. |
that is not sufficient. it will cause too many rebuilds. the staging-next cycle is nearing the end and this will cause a darwin stdenv rebuild and thus require another week of building just due to this change. unless there are special circumstances, if a change can go into master it can go into staging-next otherwise it needs to target staging. |
okay, I'll change targeted branch to staging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: misilelaboratory <[email protected]>
https://cmake.org/cmake/help/latest/release/3.31.html
https://gitlab.kitware.com/cmake/cmake/-/compare/v3.31.3...v3.31.5
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.