Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib.systems: replace gcc attributes with cpu options #376197

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RossComputerGuy
Copy link
Member

@RossComputerGuy RossComputerGuy commented Jan 23, 2025

Things done

Replaces #313539, this is a better attempt and will include backwards compatibility. Still WIP.

Goals & motivations:

  • Kill lib.systems.architectures
  • Always specifying the CPU model inside the stdenv
  • Compiler flag checks within nixpkgs during the eval phase
  • Multiple toolchain compatibility
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: lib The Nixpkgs function library label Jan 23, 2025
@RossComputerGuy RossComputerGuy force-pushed the feat/cpu-model-refactor branch 7 times, most recently from 51e4486 to abe463b Compare January 24, 2025 00:31
@github-actions github-actions bot added the 6.topic: stdenv Standard environment label Jan 24, 2025
@RossComputerGuy RossComputerGuy force-pushed the feat/cpu-model-refactor branch from abe463b to 0716e76 Compare January 24, 2025 00:38
@github-actions github-actions bot removed the 6.topic: stdenv Standard environment label Jan 24, 2025
@RossComputerGuy RossComputerGuy force-pushed the feat/cpu-model-refactor branch from 0716e76 to f59ae88 Compare January 24, 2025 00:40
@RossComputerGuy RossComputerGuy force-pushed the feat/cpu-model-refactor branch from f59ae88 to a09656f Compare January 24, 2025 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant