ut1999: on darwin, move app bundle into Applications folder and add wrapper at bin/ut1999 so nix run can start the app

[dwt]

Things done

Other GUI apps for Mac seem to uphold this structure of the output folder, and I suspect this might be the solution to nix-darwin/nix-darwin#1328

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested basic functionality of all binary files (usually in ./result/bin/)

---

Add a 👍 reaction to pull requests you find important.

[dwt]

I would love a review from @afh @philiptaron and @XenGi

[afh]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 380727

---

aarch64-darwin

✅ 1 package built:

• ut1999

[dwt]

I have noticed that I cannot start the binary with nix run .#ut1999, while the same does work for nix run nixpkgs#alacritty, so there is likely something else missing still. I would appreciate some pointer, as I can't seem to find the relevant documentation yet.

[afh]

Thanks for this, @dwt, in order to be able to nix run the ut1999 package the following patch below was necessary for me:

diff --git a/pkgs/by-name/ut/ut1999/package.nix b/pkgs/by-name/ut/ut1999/package.nix
index 033785d715c6..a0d29f7ed9c2 100644
--- a/pkgs/by-name/ut/ut1999/package.nix
+++ b/pkgs/by-name/ut/ut1999/package.nix
@@ -6,6 +6,7 @@
   undmg,
   fetchurl,
   makeDesktopItem,
+  makeWrapper,
   copyDesktopItems,
   libarchive,
   imagemagick,
@@ -67,7 +68,7 @@ let
     }
     .${stdenv.hostPlatform.system} or (throw "unsupported system: ${stdenv.hostPlatform.system}");
 in
-stdenv.mkDerivation {
+stdenv.mkDerivation (finalAttrs: {
   name = "ut1999";
   inherit version;
   sourceRoot = ".";
@@ -91,6 +92,7 @@ stdenv.mkDerivation {
       autoPatchelfHook
     ]
     ++ lib.optionals stdenv.hostPlatform.isDarwin [
+      makeWrapper
       undmg
     ];
 
@@ -104,15 +106,15 @@ stdenv.mkDerivation {
     in
     ''
       runHook preInstall
-      mkdir -p $out
+      mkdir -p $out/bin
     ''
     + lib.optionalString (stdenv.hostPlatform.isLinux) ''
-      mkdir -p $out/bin
       cp -r "./*" $out
     ''
     + lib.optionalString (stdenv.hostPlatform.isDarwin) ''
       mkdir -p $out/Applications/
       cp -r "UnrealTournament.app" $out/Applications/
+      makeWrapper $out/Applications/UnrealTournament.app/Contents/MacOS/UnrealTournament $out/bin/${finalAttrs.meta.mainProgram}
     ''
     + ''
       chmod -R 755 $out
@@ -188,4 +190,4 @@ stdenv.mkDerivation {
     sourceProvenance = with sourceTypes; [ binaryNativeCode ];
     mainProgram = "ut1999";
   };
-}
+})

[dwt]

@afh Huh, that actually looks much saner than my experiment, I'll use that.

[afh]

Thanks for accepting the patch I proposed, @dwt, much appreciated.
With the latest changes to this PR I succeeded in running ut1999 on aaarch64-darwin directly:

/usr/bin/env NIXPKGS_ALLOW_UNFREE=1 nix run --impure github:NixOS/nixpkgs/pull/380727/merge#ut1999

[philiptaron]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 380727

---

x86_64-linux

❌ 1 package failed to build:

• ut1999

[philiptaron]

ut> no configure script, doing nothing
ut> Running phase: buildPhase
ut> no Makefile or custom buildPhase, doing nothing
ut> Running phase: installPhase
ut> cp: cannot stat './*': No such file or directory

[philiptaron]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 380727

---

x86_64-linux

✅ 1 package built:

• ut1999

[dwt]

--------- Report for 'x86_64-linux' ---------
1 package built:
ut1999

--------- Report for 'aarch64-linux' ---------
1 package built:
ut1999

--------- Report for 'x86_64-darwin' ---------
1 package built:
ut1999

--------- Report for 'aarch64-darwin' ---------
1 package built:
ut1999

ah dang, too slow. :) Thanks for merging!