Lambda enclosed in aligned parens to support Elm language server parsing #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zwilias
reviewed
Mar 31, 2022
There was a problem hiding this comment.
I'm going to let the tests do their thing (assuming CI works), but honestly, this looks good! (At least, the updated "golden" tests look good!)
In the meantime, you can also use this locally by running niv update servant-elm -b kraken/emit-expect-compatible-with-elm-language-server within the tooling/ directory (and running firstaide-update right after).
That should at least tell you whether changes look good (enough), or whether further tweaks are needed.
Feel free to poke me if you want a hand with that!
|
It worked as intended! See this PR. |
|
Sweet! I'll go ahead and merge this and put in a PR to update the monorepo 👍 |
zwilias
deleted the
kraken/emit-expect-compatible-with-elm-language-server
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of this item I have need to generate some Elm API endpoints from Rostering.
The current generation breaks the parsing of the Elm Language server that is used by VS Code (at least, probably other setups as well) and this leads to a really bad developer experience. Not only are errors reported in the generated files but also any Elm files that depend on those generated artifacts (ex. Curriculum).
This PR attempts to fix it by simply emitting lambdas wrapped in column aligned parenthesis.
It is a really small change. I updated 1 code file and 11 expectations.
Prior to the Fix
After the Fix