Add X-Requested-With: XMLHttpRequest to all requests #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's a constant source of confusion as the instance is present for CI (presumably because its build with slack, but locally with cabal the instance is missing?). Perhaps a different version of something is being pulled in.
omnibs
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have annoying issues crop up periodically with DELETE requests (silently) requiring a CSRF token when other request types don't.
This stems from the following code, which shows its actually the body content-type being JSON that matters - and DELETES just happen to not typically have bodies.
https://github.com/NoRedInk/NoRedInk/blob/387f54e9db092e4188116bd8d2daa06460dd8bcc/monolith/app/controllers/application_controller.rb#L117
So instead this PR adds the X-Requested-With: XMLHttpRequest header to all requests.