-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add foundryup
support for Windows
#515
base: development
Are you sure you want to change the base?
Add foundryup
support for Windows
#515
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## development #515 +/- ##
==============================================
Coverage ? 53.22%
==============================================
Files ? 188
Lines ? 4825
Branches ? 793
==============================================
Hits ? 2568
Misses ? 2020
Partials ? 237 |
@kanej Do you think this fix looks acceptable? I don't have a Windows box but I imagine that installing through
Now installs to |
@@ -25,6 +25,9 @@ release. | |||
|
|||
9. Push the release branch and open a pull request using the new changelog entry as the PR description | |||
10. Generate a release candidate vsix file with `npm run package`, the vsix file should appear in the `./client` folder with the new version number | |||
|
|||
> NOTE: ensure .env file is populated with GA and Sentry secrets before packaging (see `./env.example`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we drop this change, please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was the dev branch pulled back? I didn't add that. @kanej
But yeah, kinda cool that the PR is still valid after 10 months.
This PR adds support for
foundryup
on Windows, especially ifforge
is not available inpath
or conflicts with other globally installed packages.