-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Semantic highlight and document symbols on slang 0.10 #523
Semantic highlight and document symbols on slang 0.10 #523
Conversation
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## development #523 +/- ##
==============================================
Coverage ? 52.66%
==============================================
Files ? 228
Lines ? 5317
Branches ? 835
==============================================
Hits ? 2800
Misses ? 2279
Partials ? 238 ☔ View full report in Codecov by Sentry. |
c93765e
to
bcc6c11
Compare
server/src/services/semanticHighlight/highlighters/StringHighlighter.ts
Outdated
Show resolved
Hide resolved
server/src/services/semanticHighlight/highlighters/StructDefinitionHighlighter.ts
Show resolved
Hide resolved
ab6120a
to
d0fb8f4
Compare
d0fb8f4
to
f3095bd
Compare
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat is an invalid package.json?Package has an invalid package.json and can cause installation problems if you try to use it. Fix syntax errors in the invalid package.json and publish a new version with a valid package.json. Consumers can use npm overrides to force a version that does not have this problem if one exists. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
* feat: semantic highlighting * feat: documentSymbol - project outline * chore: migrate to slang 0.10.1 semantic highlight * track performance spans * error tolerance for document symbols * decouple onSemanticTokens from solidity-parser * optimize walking by storing references * leverage trackTimingSync error handling * enable documentSymbol and semanticHighlight only on slang-supported platforms * feature flags * use finders for walking the cst * rework semantic highlighting to use cursor finders * fix linter * Changes based on PR feedback (part 1) * Support unnamed function definition on documentSymbols * refactor based on feedback * moving version selection to slangHelpers * add comment to semantic tokens test
* feat: semantic highlighting * feat: documentSymbol - project outline * chore: migrate to slang 0.10.1 semantic highlight * track performance spans * error tolerance for document symbols * decouple onSemanticTokens from solidity-parser * optimize walking by storing references * leverage trackTimingSync error handling * enable documentSymbol and semanticHighlight only on slang-supported platforms * feature flags * use finders for walking the cst * rework semantic highlighting to use cursor finders * fix linter * Changes based on PR feedback (part 1) * Support unnamed function definition on documentSymbols * refactor based on feedback * moving version selection to slangHelpers * add comment to semantic tokens test
This PR includes support for two new language features, semantic highlighting and document symbols (project outline).
It achieves so by making use of the latest version of slang (0.10.1)
These are some key points from this PR:
Closes #217
Closes #42
Closes #491