Add bindings test to Sanctuary #1159
Open
+146
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sanctuary bundles all dependencies in the same source file, so all imports should resolve to the same, sole file.
This happens when there is special member access in some Yul identifier (like `x.slot` or `x.offset`). I think this issue was introduced when unreserving the `address` keyword since that changed the structure of `YulPath`. There is a proper test case in NomicFoundation#1149 already, but without this fix running Sanctuary with existing rules crashes.
|
OmarTawfik
reviewed
Nov 26, 2024
OmarTawfik
reviewed
Nov 26, 2024
OmarTawfik
reviewed
Nov 26, 2024
OmarTawfik
reviewed
Nov 26, 2024
There was a problem hiding this comment.
Left a couple of non-blocking questions. Mainly this: #1159 (comment)
ggiraldez
force-pushed
the
sanctuary-bindings-testing
branch
from
d748a16
to
58b8f91
Compare
OmarTawfik
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a step to Sanctuary testing to exercise bindings. We now also consider a Sanctuary test to fail if any of the references found in it cannot be resolved to one (or possibly more) definitions.
This also includes a small binding rules fix to avoid crashing if we find a Solidity source file with an assembly block that has a
YulPathwith more than one identifier (eg. a member access likex.slot). This is properly tested in #1149, but without it running Sanctuary tests will crash since there are contracts with the aforementioned contents.