-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Output graph files to target
directory and improve Graphviz output
#1167
Output graph files to target
directory and improve Graphviz output
#1167
Conversation
|
crates/solidity/outputs/cargo/tests/src/bindings_output/graph/graphviz.rs
Outdated
Show resolved
Hide resolved
crates/solidity/outputs/cargo/tests/src/bindings_output/runner.rs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few suggestions. Thanks!
The graph files
.mmd
and.dot
files are not committed to the repository and hence writing them to the source directory (inside thegenerated
folder) does not provide any benefit and even has some drawbacks (eg. build errors when switching branches and test are no longer present). This PR changes the output directory to be inside thetarget
directory in thesolidity_cargo_tests
crate directory.These output files are opt-in via a
RENDER_GRAPHS
environment variable. The performance impact of their generation is not too big, but they are generally unnecessary unless we're debugging binding rules.There are also some tweaks and added information to the
.dot
file output to improve graph readability and make tracing nodes to rules easier.