Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix request.data handling #436

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Fix request.data handling #436

merged 1 commit into from
Nov 18, 2024

Conversation

mrlika
Copy link
Member

@mrlika mrlika commented Nov 17, 2024 •
edited
Loading

request.data is always undefined here that causes peers' protocol failure:

const isWrongSegment =
  !request.data ||
  downloadingContext.request.segment.externalId !== command.i ||
  downloadingContext.requestId !== command.r;

@DimaDemchenko DimaDemchenko merged commit 7f2f1fa into main Nov 18, 2024
3 checks passed
@DimaDemchenko DimaDemchenko deleted the fix/data-handling branch November 18, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DimaDemchenko DimaDemchenko DimaDemchenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrlika @DimaDemchenko