Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove ESRI Shapefile #72

Merged
merged 2 commits into from
Dec 2, 2024
Merged

remove ESRI Shapefile #72

merged 2 commits into from
Dec 2, 2024

Conversation

rsbivand
Copy link
Contributor

@rsbivand rsbivand commented Dec 1, 2024

Further to #62

@Robinlovelace
Copy link
Collaborator

Looks good to me.

@Nowosad
Copy link
Owner

Nowosad commented Dec 2, 2024

Thanks @rsbivand -- should I submit it to CRAN soon or should I wait a week or two?

@Nowosad Nowosad merged commit 2d080ad into Nowosad:master Dec 2, 2024
1 check passed
@rsbivand
Copy link
Contributor Author

rsbivand commented Dec 2, 2024

Maybe wait for spdep (published on CRAN 2024-12-02 14:23), spatialreg (published on CRAN 2024-12-02 12:43) and sphet to complete? See #62 (comment), @gpiras said he hopes to submit this week - done, I'll try to submit today - done.

@Nowosad
Copy link
Owner

Nowosad commented Dec 2, 2024

👍🏻

@rsbivand
Copy link
Contributor Author

rsbivand commented Dec 2, 2024

Extra undeclared reverse dependency: ref.ICAR, maintainer acknowledged by email, and spmoran - dmuraka/spmoran#4 and email.

@rsbivand
Copy link
Contributor Author

rsbivand commented Dec 4, 2024

spmoran on CRAN.

@gpiras
Copy link

gpiras commented Dec 5, 2024

@rsbivand sphet is not. I was checking the package on my mac and everything was fine so I submitted. However, the checks fail in Windows and Debian (see mail below). I will try later to fix the problem with Ubuntu, but I don't have windows so this might take longer than expected.

Dear maintainer,

package sphet_2.1.tar.gz does not pass the incoming checks automatically, please see the following pre-tests (additional issue checks):
Windows: https://win-builder.r-project.org/incoming_pretest/sphet_2.1_20241205_174314/Windows/00check.log
Status: 1 NOTE
Debian: https://win-builder.r-project.org/incoming_pretest/sphet_2.1_20241205_174314/Debian/00check.log
Status: 1 NOTE

@rsbivand
Copy link
Contributor Author

rsbivand commented Dec 5, 2024

The default version of HTML tidy is from 2006 on macOS https://stat.ethz.ch/pipermail/r-sig-mac/2022-May/014443.html. If you can install an updated version, that will help. Is the github repo up-to-date, seems to be last pushed in June? I can pull and check if that helps.

@gpiras
Copy link

gpiras commented Dec 5, 2024

I have installed version 5.8.0 (https://github.com/htacg/tidy-html5/releases/download/5.8.0/tidy-5.8.0-macos-x86_64+arm64.dmg), but no help. github is up-to-date now. Sure if you could do that it would be great!

@rsbivand
Copy link
Contributor Author

rsbivand commented Dec 5, 2024

Did you push the version you submitted to CRAN to the github repo?

@gpiras
Copy link

gpiras commented Dec 5, 2024

yes. built and check with no problems on mac.

@rsbivand
Copy link
Contributor Author

rsbivand commented Dec 5, 2024

@gpiras Created gpiras/sphet#22, hope it helps; I don't see the NOTE.

@rsbivand
Copy link
Contributor Author

rsbivand commented Dec 6, 2024

I've emailed the GWnnegPCA maintainer at a university email and hope that helps.

@rsbivand
Copy link
Contributor Author

rsbivand commented Dec 6, 2024

sphet on CRAN, thanks @gpiras

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants