Avoid implicit conversion from sexp to double
#39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cpp11 currently allows some somewhat scary implicit conversions between
sexpand the 3 typesbool,size_t, anddouble. These are unchecked conversions, and we'd like to remove them:r-lib/cpp11#390
The recommended way is to use
cpp11::as_cpp<double>(), which checks the type and length before performing the conversion, and is also explicit, which is a good thing for this kind of conversion.I'm not going to remove these in the upcoming version of cpp11, but we will in the next after that