feat: add date-time-local and time-local. #4760
Conversation
handrews
added
format-registry
registries
|
@baywet @mikekistler thoughts? |
|
No objection from me. |
| The `{{page.slug}}` format represents a time without timezone for [TOML Local Time](https://toml.io/en/v1.0.0#local-time) compatibility. | ||
| {% endcapture %} | ||
|
|
||
| {% include format-entry.md summary=summary %} |
There was a problem hiding this comment.
Why are we not also including date local?
There was a problem hiding this comment.
Since Time Zone is tied to time, date-local was not suggested.
registries/_format/time-local.md
Outdated
| --- | ||
| owner: ya7010 | ||
| issue: 4759 | ||
| description: time without timezone |
There was a problem hiding this comment.
Maybe mention it's based on RFC 3339?
There was a problem hiding this comment.
Time zone is required by RFC 3339.
This PR proposes a format without time zone, which is not defined in the RFC but defined in TOML.
There was a problem hiding this comment.
sorry, what I meant was maybe we should update the text to say something like "RFC3339 time without the timezone component" to clarify the base for it is the RFC
There was a problem hiding this comment.
I misunderstood.
That makes sense.
| @@ -0,0 +1,15 @@ | |||
| --- | |||
There was a problem hiding this comment.
For the name, I've seen programming languages call this a time only. I think it'd be interesting to see whether multiple languages use the same name (time only or otherwise) and check whether it's worth using a different name for clarity.
There was a problem hiding this comment.
Your point is correct.
On the other hand, the already existing time and date-time format follow RFC3339, and thus enforce the time zone.
So, I think the proposed format with *-local is the right direction.
There was a problem hiding this comment.
I agree that given that time is already a format, time-local seems the most clear. Unless you had a specific alternative in mind @baywet ?
There was a problem hiding this comment.
time-only was the alternative I was thinking about here. But I'm probably coming with too much of a dotnet angle
java calls it local time
go uses the same struct for everything
I guess I'm good with time-local, resolving.
There was a problem hiding this comment.
(well, I can't resolve, please go ahead and resolve this comment)
Fix: #4759