Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] base_transaction_id: Migration to 16.0 #524

Merged
merged 43 commits into from
Mar 23, 2023

Conversation

dzungtran89
Copy link

@dzungtran89 dzungtran89 commented Feb 20, 2023

Note: this migration is based on this PR

yvaucher and others added 30 commits February 20, 2023 11:21
(lp:c2c-financial-addons/6.1 rev 24.1.5)
…t working yet, just for backup)

(lp:c2c-financial-addons/6.1 rev 24.1.8)
…ll as on the automatic reconciliation wizard.

(lp:c2c-financial-addons/6.1 rev 24.1.10)
…eed both finaly

(lp:c2c-financial-addons/6.1 rev 24.1.15)
(lp:c2c-financial-addons/6.1 rev 58)
…ostly based on :

  account_statement_ext -> provide profile per bank statement, remove period, choose to use balance check or not,...
  account_statement_base_completion -> provide a completion rule system to fullfill the bank statement (partner, account,...)
  account_statement_base_import -> provide a base to create your own file parser for each bank/office and link it to a profile
  account_statement_transactionid_completion and account_statement_transactionid_import to use the transaction ID recorded in th SO
  account_advanced_reconcile -> An advanced way to setup reconciliation rules on every account
  account_financial_report_webkit -> some little fixes
(lp:c2c-financial-addons/6.1 rev 63)
- Adapt import to fit last recomandation
- Import osv for osv.except
- pep8, pylint, eyeballing
- standardize the naming of the argument 'cr' instead of 'cursor'
- Remove the active key in the __openerp__.py
…me account than the invoice's one (the payable / receivable)
- Use the 'data' key instead of 'update_xml'
- Use the new api for account.invoice as the base model use it
- The module now depends on 'sale_stock' and 'stock_account'
- Avoid to write 2 times on the invoice by using the method that
  prepares the values before the write
- Empty the transaction id of a sale order on copy
- Some cleaning
- Indent xml with 2 spaces
- Cleaning of the views
- Add the transaction ref field to the form view of the move lines
In order to get visibility on https://www.odoo.com/apps the OCA board has
decided to add the OCA as author of all the addons maintained as part of the
association.
Add the field inside the group instead of after a field.  In another module, I
add a button right after 'payment_term' and it must be right after it.  Adding
the field in the group prevent it to be placed between the payment_term field
and the button.
- Reactivate module
- move files in views and models dirs
- create README.rst from description
- make list of contributors
- remove change for invoice created on picking as it doesn't exist
anymore in Odoo Community
- move overrides in bank statement as logic moved in move lines
- adapt view inheritance to not depends on string attribute
- Fix definition of javascript customization in reconciliation
- Fix display transaction_ref label on move line view
- Fix move proposition for reconcile. search with transaction_ref
- Use short headers
- Update README for bug tracking
- Translation template files.
- former Launchpad automatic translations update.
Currently translated at 100,0% (8 of 8 strings)

Translation: account-reconcile-11.0/account-reconcile-11.0-base_transaction_id
Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-11-0/account-reconcile-11-0-base_transaction_id/de/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-reconcile-12.0/account-reconcile-12.0-base_transaction_id
Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-12-0/account-reconcile-12-0-base_transaction_id/
Copy link

@leemannd leemannd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@RodrigoBM
Copy link

issue: #497

@RodrigoBM
Copy link

@dzungtran89 can you change name PR, Thanks

  • For being easily searchable and avoiding to duplicate efforts, please name the pull request following this pattern: [16.0][MIG] : Migration to 16.0

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-16.0#technical-method-to-migrate-a-module-from-150-to-160-branch

@RodrigoBM
Copy link

RodrigoBM commented Mar 15, 2023

@leemannd can you merge it?, thanks

@dzungtran89 dzungtran89 changed the title [MIG] base_transaction_id: Migration to 16.0 [16.0][MIG] base_transaction_id: Migration to 16.0 Mar 15, 2023
@dzungtran89
Copy link
Author

dzungtran89 commented Mar 15, 2023

Hello @RodrigoBM , thanks for the review, I updated the PR's title

@leemannd
Copy link

Hello @RodrigoBM I'm not PSC on this repository so I don't have merge rights. Has someone from @OCA/accounting-maintainers time to have a quick look about it?

@RodrigoBM
Copy link

@leemannd Im sorry, I thought you had permissions

@gurneyalex
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-524-by-gurneyalex-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit e6c34c0 into OCA:16.0 Mar 23, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 0a38f4d. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.