Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][IMP] stock_buffer_route: Add alternative item type in buffer #308

Closed
wants to merge 2 commits into from
Closed

[14.0][IMP] stock_buffer_route: Add alternative item type in buffer #308

wants to merge 2 commits into from

Conversation

BernatPForgeFlow
Copy link
Member

@BernatPForgeFlow BernatPForgeFlow commented Jul 31, 2023 •
edited
Loading

Depends on #311

@BernatPForgeFlow BernatPForgeFlow force-pushed the 14.0-imp-stock_buffer_route branch 4 times, most recently from 90f6300 to 0288733 Compare August 3, 2023 07:37
@BernatPForgeFlow BernatPForgeFlow force-pushed the 14.0-imp-stock_buffer_route branch 4 times, most recently from b638137 to b6e8f17 Compare September 26, 2023 08:15
@BernatPForgeFlow BernatPForgeFlow mentioned this pull request Dec 5, 2023
Closed
@LoisRForgeFlow
Copy link
Contributor

@BernatPForgeFlow I think here there are several things mixed. Could you keep here only "[IMP] stock_buffer_route: Select route in procurement wizard", and move the other commits to a separate PR (my current thought is that those alternative fields should be either a customization or a separated module) so we can discuss individually?

@PauBForgeFlow PauBForgeFlow mentioned this pull request Dec 27, 2023
Closed
@LoisRForgeFlow LoisRForgeFlow changed the title [14.0][IMP] stock_buffer_route: Select route in procurement wizard [14.0][IMP] stock_buffer_route: Add alternative item type in buffer Jan 15, 2024
@LoisRForgeFlow
Copy link
Contributor

@BernatPForgeFlow I think here there are several things mixed. Could you keep here only "[IMP] stock_buffer_route: Select route in procurement wizard", and move the other commits to a separate PR (my current thought is that those alternative fields should be either a customization or a separated module) so we can discuss individually?

Done here #379 and kept this PR for the additional changes.

@LoisRForgeFlow
Copy link
Contributor

@BernatPForgeFlow could you now solve conflicts?

@BernatPForgeFlow
[IMP] stock_buffer_route: Add alternative item type in buffer
3ce6de2 
Considering that the 'Route' field will be used to define a different way to procure, a field called 'Alternative Item Type' is added in the Stock Buffer.
This will help improve the search with the filters and enhance the calculations by taking the alternative route into account.
@BernatPForgeFlow
[IMP] stock_buffer_route: Do not consider other locations Buy routes
96992fa 
Considering all buy routes should not be the default behaviour. If this is needed should be in a customized module.
@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 18, 2024
@github-actions github-actions bot closed this Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs fixing stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BernatPForgeFlow @LoisRForgeFlow