Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] ddmrp_chatter: Migration to 16.0 #315

Merged
merged 13 commits into from
Oct 18, 2023
Merged

[16.0][MIG] ddmrp_chatter: Migration to 16.0 #315

merged 13 commits into from
Oct 18, 2023

Conversation

AlexPForgeFlow
Copy link
Contributor

@AlexPForgeFlow AlexPForgeFlow commented Aug 17, 2023 •
edited
Loading

Migration to 16.0

ForgeFlow

@AlexPForgeFlow AlexPForgeFlow force-pushed the 16.0-mig-ddmrp_chatter branch 3 times, most recently from e75ca1e to 33022ed Compare August 17, 2023 11:13
@AlexPForgeFlow AlexPForgeFlow mentioned this pull request Aug 17, 2023
Merged
mariadforgeflow
mariadforgeflow approved these changes Aug 17, 2023
View reviewed changes
Copy link

@mariadforgeflow mariadforgeflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

BernatPForgeFlow
BernatPForgeFlow approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@BernatPForgeFlow BernatPForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@LoisRForgeFlow
Copy link
Contributor

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

@LoisRForgeFlow The rebase process failed, because command git push --force ForgeFlow tmp-pr-315:16.0-mig-ddmrp_chatter failed with output:

remote: Permission to ForgeFlow/ddmrp.git denied to OCA-git-bot.
fatal: unable to access 'https://github.com/ForgeFlow/ddmrp/': The requested URL returned error: 403

@LoisRForgeFlow LoisRForgeFlow force-pushed the 16.0-mig-ddmrp_chatter branch 2 times, most recently from c48c03c to 921f107 Compare October 11, 2023 15:37
@LoisRForgeFlow
Copy link
Contributor

Rebased after dependency merge and deleted test requirements.

However, I found that commits history is not complete. @AlexPForgeFlow you need to migrate from the most recent version in which the module is available. This module was in v15 (https://github.com/OCA/ddmrp/commits/15.0/ddmrp_chatter) and you have migrated it from v14. Could you correct this?

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

LoisRForgeFlow
LoisRForgeFlow approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-315-by-LoisRForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 934aac4 into OCA:16.0 Oct 18, 2023
6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 1e74d64. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BernatPForgeFlow BernatPForgeFlow BernatPForgeFlow approved these changes

@mariadforgeflow mariadforgeflow mariadforgeflow approved these changes

@LoisRForgeFlow LoisRForgeFlow LoisRForgeFlow approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@AlexPForgeFlow @LoisRForgeFlow @OCA-git-bot @mariadforgeflow @BernatPForgeFlow @oca-travis @DavidBForgeFlow @ChrisOForgeFlow