Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0] edi_sale_oca: use edi.configuration #1067

Merged
merged 2 commits into from
Dec 4, 2024
Merged

[14.0] edi_sale_oca: use edi.configuration #1067

merged 2 commits into from
Dec 4, 2024

Conversation

simahawk
Copy link
Contributor

@simahawk simahawk commented Nov 14, 2024 •
edited
Loading

Depends on

@simahawk simahawk added this to the 14.0 milestone Nov 14, 2024
This was referenced Nov 14, 2024
Merged
Closed
Open
@simahawk simahawk mentioned this pull request Nov 28, 2024
Merged
@simahawk simahawk force-pushed the 14-edi_sale+conf branch 3 times, most recently from 2dd3371 to 7ce9461 Compare December 2, 2024 14:57
@simahawk
Copy link
Contributor Author

simahawk commented Dec 2, 2024

@JordiMForgeFlow would you mind to have a look at this?
I'll work on sale ubl and purchase ubl as well in the same fashion (using new edi.configuration model) and you'll likely benefit from it in v17 ;)

SilvioC2C
SilvioC2C approved these changes Dec 3, 2024
View reviewed changes
Copy link

@SilvioC2C SilvioC2C left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, one small imrpovement suggested

edi_sale_oca/demo/edi_configuration.xml
# ('done', 'Locked'),
# ('cancel', 'Cancelled'),
if record.state == 'sale':
record._edi_send_via_edi(conf.type_id)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be useful to add help text explaining which variables are available to use in the snippet (like Odoo does by default for server actions or crons)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

variables come from edi_oca. I'll check there.

@simahawk
Copy link
Contributor Author

simahawk commented Dec 3, 2024

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-1067-by-simahawk-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Dec 3, 2024
@OCA-git-bot
Merge PR #1067 into 14.0
3884ec3 
Signed-off-by simahawk
@OCA-git-bot
Copy link
Contributor

@simahawk your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-1067-by-simahawk-bump-minor.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@simahawk
Copy link
Contributor Author

simahawk commented Dec 4, 2024

Build on 14.0 is broken #1084

@simahawk
Copy link
Contributor Author

simahawk commented Dec 4, 2024

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-1067-by-simahawk-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 400fd00 into OCA:14.0 Dec 4, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 7080227. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SilvioC2C SilvioC2C SilvioC2C approved these changes

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
14.0
Development

Successfully merging this pull request may close these issues.
3 participants
@simahawk @OCA-git-bot @SilvioC2C