[14.0][IMP] product_import: currency can be implicit #1094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twalter-c2c
reviewed
Dec 9, 2024
florentx
force-pushed
the
product_import_no_currency
branch
from
24e66d8 to
c99b040
Compare
|
Fixed. |
florentx
force-pushed
the
product_import_no_currency
branch
from
c99b040 to
4f3a811
Compare
twalter-c2c
approved these changes
Dec 9, 2024
florentx
force-pushed
the
product_import_no_currency
branch
from
4f3a811 to
71bb0b7
Compare
simahawk
approved these changes
Dec 10, 2024
|
A test would be nice... as usual 😉 |
|
This PR has the |
florentx
force-pushed
the
product_import_no_currency
branch
4 times, most recently
from
0088109 to
e83c22c
Compare
It is needed in order to have a safe recomputation of fields of other models. There was an issue in a third-party add-on which has a field recomputed when a new 'product.supplierinfo' is added to 'seller_ids' of the product.
florentx
force-pushed
the
product_import_no_currency
branch
from
e83c22c to
f6982ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When currency was not on each catalogue line, there was tons of warnings on importation.
[ EDIT ]
Rebased on top of refactor PR: