Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] remove pin version of dateparser #716

Merged
merged 2 commits into from
Sep 3, 2023

Conversation

florian-dacosta
Copy link
Contributor

Issue reported here #544 is fixed in recent version of dateparser.
Fixed here I believe : scrapinghub/dateparser#1045

@OCA-git-bot
Copy link
Contributor

Hi @alexis-via,
some modules you are maintaining are being modified, check this out!

@florian-dacosta
Copy link
Contributor Author

@simahawk

@simahawk
Copy link
Contributor

shall we pin dateparser >= $minor_version_with_the_fix?

Copy link
Contributor

@bosd bosd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fasttrack this. As the module is not installable due to a version conflict!

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 11, 2023
@bosd
Copy link
Contributor

bosd commented Jun 11, 2023

shall we pin dateparser >= $minor_version_with_the_fix

LGTM

@rvalyi
Copy link
Member

rvalyi commented Jun 11, 2023

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-716-by-rvalyi-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jun 11, 2023
Signed-off-by rvalyi
@OCA-git-bot
Copy link
Contributor

@rvalyi your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-716-by-rvalyi-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 18, 2023
@bosd
Copy link
Contributor

bosd commented Sep 2, 2023

@florian-dacosta @rvalyi Can you attend to this?

@rvalyi
Copy link
Member

rvalyi commented Sep 2, 2023

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-716-by-rvalyi-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Sep 2, 2023
Signed-off-by rvalyi
@OCA-git-bot
Copy link
Contributor

@rvalyi your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-716-by-rvalyi-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@bosd
Copy link
Contributor

bosd commented Sep 2, 2023

Why does it fail?

florian-dacosta and others added 2 commits September 2, 2023 18:32
Issue reported here OCA#544 is fixed in recent version of dateparser
@rvalyi
Copy link
Member

rvalyi commented Sep 2, 2023

@bosd @florian-dacosta the merge failed because dateparser was still pinned to the old version in edi_pdf2data_oca/__manifest__.py so the requirements.txt generation would still pick the pinned version and be different than it was in the PR.
I fixed that in a fixup! commit.

Still OK with the PR?

@bosd
Copy link
Contributor

bosd commented Sep 3, 2023

Yes, please proceed

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@rvalyi
Copy link
Member

rvalyi commented Sep 3, 2023

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-716-by-rvalyi-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 7bec2a0 into OCA:14.0 Sep 3, 2023
6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 7274aa6. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants