-
-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] remove pin version of dateparser #716
Conversation
Hi @alexis-via, |
7af0aca
to
c641c33
Compare
shall we pin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fasttrack this. As the module is not installable due to a version conflict!
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
LGTM |
/ocabot merge patch |
Hey, thanks for contributing! Proceeding to merge this for you. |
@rvalyi your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-716-by-rvalyi-bump-patch. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
@florian-dacosta @rvalyi Can you attend to this? |
/ocabot merge patch |
Hey, thanks for contributing! Proceeding to merge this for you. |
@rvalyi your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-716-by-rvalyi-bump-patch. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
Why does it fail? |
c641c33
to
a83a1a0
Compare
@bosd @florian-dacosta the merge failed because dateparser was still pinned to the old version in Still OK with the PR? |
Yes, please proceed |
This PR has the |
/ocabot merge patch |
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at 7274aa6. Thanks a lot for contributing to OCA. ❤️ |
Issue reported here #544 is fixed in recent version of dateparser.
Fixed here I believe : scrapinghub/dateparser#1045