[14.0][IMP] edi_oca: Do not retry exchange_send indefinitely #980
Conversation
| job.perform() | ||
| with freeze_time("2024-01-11 08:50:00"): | ||
| # + 23 hours and 50 minutes | ||
| job = self.backend.with_delay().exchange_send(record) |
There was a problem hiding this comment.
Why not using the same job you've got before?
However, if the identity_key works well, here you should get still the same job but I think is useless to call send again.
| job = self.backend.with_delay().exchange_send(record) | ||
| res = job.perform() | ||
| self.assertIn("Error", res) | ||
| job_counter.search_created() |
There was a problem hiding this comment.
this search seems useless as you don't use the result
| raise RetryableJobError( | ||
| error, **exchange_record._job_retry_params() | ||
| ) from err | ||
| if self._send_should_retry(exchange_record): |
There was a problem hiding this comment.
Thinking out loud...
In theory a case where we spawn another job for the same record should not exist thanks to the identity_key.
Hence, I assume that jobs won't be retried infinitely if we reach the max retry job count.
If this does not happen it means the identity_key is not working and we end up w/ more than one job to send the same record.
Am I wrong?
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
gurneyalex
added
no stale
Sometimes the backend is badly configured, with invalid URL. Or there might be other conditions.
It happens more frequently on Dev or Test server instances.
In such case we don't want to insist sending Exchange Record indefinitely.
Supersedes #960