[17.0][MIG] fieldservice_geoengine: Migration to 17.0

[peluko00]

Module migrated to version 17.0

cc https://github.com/APSL 155457
@miquelalzanillas @lbarry-apsl @javierobcn @mpascuall please review

• [Issue] Migration to version 17.0 #1132

Depends on:

• [base_geoengine] [17.0][MIG] base_geoengine: Migration to 17.0  geospatial#368

[peluko00]

Hi @sersanchus, i have a problem when enter to map view for a problem with source.

The problem is in base_geoengine that we work together but i don't know why is throwing this error. Any idea to solve that?

Thanks in advance

[sersanchus]

Hi @peluko00,

The error is related to this piece of code not finding any vec layer:

var extent = this.vectorLayersResult .find((res) => res.values_.visible === true) .getSource() .getExtent();

As all openlayers vec layers are visible by default, maybe there aren't any 'geoengine.vector.layer' associated with the geoengine view of your demo. In that case 'getOriginalZoom' has to detect that and use for example an empty extent in taht case:

ol.extent.createEmpty()

[peluko00]

Hi @peluko00,

The error is related to this piece of code not finding any vec layer:

var extent = this.vectorLayersResult .find((res) => res.values_.visible === true) .getSource() .getExtent();

As all openlayers vec layers are visible by default, maybe there aren't any 'geoengine.vector.layer' associated with the geoengine view of your demo. In that case 'getOriginalZoom' has to detect that and use for example an empty extent in taht case:

ol.extent.createEmpty()

I found the error, is because any of the 'geoengine.vector.layer' hasn't a field called 'active_on_startup' seted to True.
Normally base_geonegine needs one at least.

Many thanks!

[mpascuall]

Working good, checked in runboat

[miquelalzanillas]

Working as expected on runboat.

LGTM!

[max3903]

/ocabot migration fieldservice_geoengine

[dreispt]

/ocabot merge nobump

[OCA-git-bot]

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-1190-by-dreispt-bump-nobump, awaiting test results.

[OCA-git-bot]

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 17.0-ocabot-merge-pr-1190-by-dreispt-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

[peluko00]

@dreispt Maybe it's for the dependency that not being merge?

[peluko00]

@max3903 @dreispt It's ready to be merge

[max3903]

/ocabot merge nobump

[OCA-git-bot]

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-1190-by-max3903-bump-nobump, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 82227a0. Thanks a lot for contributing to OCA. ❤️