Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][MIG]fieldservice_project #724

Merged
merged 34 commits into from
May 27, 2021
Merged

[14.0][MIG]fieldservice_project #724

merged 34 commits into from
May 27, 2021

Conversation

Freni-OSI
Copy link
Contributor

No description provided.

@brian10048 brian10048 added this to the 14.0 milestone Feb 24, 2021
fshah-initos
fshah-initos approved these changes Mar 23, 2021
View reviewed changes
Copy link

@fshah-initos fshah-initos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review and Functional test. LGTM

@Freni-OSI Freni-OSI mentioned this pull request Apr 13, 2021
Open
43 tasks
@fshah-initos
Copy link

Hi @Freni-OSI Can please have a look at above comments?

@Freni-OSI Freni-OSI force-pushed the 14_MIG_fieldservice_project branch 2 times, most recently from 4af8a29 to ed2644e Compare April 14, 2021 14:08
@fshah-initos
Copy link

fshah-initos commented Apr 30, 2021 •
edited
Loading

It would be great if somone could add reviews and merge the PR.

@brian10048
Copy link
Contributor

@Freni-OSI we have since merged this to v13 which has increased tests coverage and also includes a minor bug fix.
Can you please rebase your migration to reflect these v13 improvements?

See #772 and #776

@fshah-initos
Copy link

Hi @Freni-OSI It would be great if you could look at above comments.

@Freni-OSI Freni-OSI force-pushed the 14_MIG_fieldservice_project branch from 4953cde to f6856ba Compare May 10, 2021 12:49
@Freni-OSI
Copy link
Contributor Author

Hi @Freni-OSI It would be great if you could look at above comments.

for sure. Thanks for the update.

@brian10048
Copy link
Contributor

@Freni-OSI can you rebase your migration so that the commit history from v13 remains? It looks like you included the changes to the code, but the commits are not present

patrickrwilson and others added 15 commits May 11, 2021 11:17
@patrickrwilson @Freni-OSI
[Add] fieldservice_project
594d6bf 
This adds a module to allow field service orders to be created from projects and project tasks.
@patrickrwilson @Freni-OSI
[UPD] Review Suggestions
d1335de 
updated with reviewer suggestions.
@patrickrwilson @Freni-OSI
[FIX] LINT Error
ef6f58e 
fixed lint error (missing OCA in authors)
@patrickrwilson @max3903 @Freni-OSI
Update fieldservice_project/__manifest__.py
a89200a 
Co-Authored-By: Maxime Chambreuil <[email protected]>
@patrickrwilson @max3903 @Freni-OSI
Update fieldservice_project/readme/CONTRIBUTORS.rst
ec95395 
Co-Authored-By: Maxime Chambreuil <[email protected]>
@OCA-git-bot @Freni-OSI
[UPD] README.rst
8204446
@max3903 @Freni-OSI
[FIX] fieldservice_project
5f762a4
@max3903 @Freni-OSI
[FIX] fieldservice_project
610febb
@max3903 @Freni-OSI
[FIX] fieldservice_project: CSS download failure (OCA#385)
50c6457
@oca-travis @Freni-OSI
[UPD] Update fieldservice_project.pot
985478f
@marylla @Freni-OSI
Added translation using Weblate (German)
2fe9a9a
@marylla @Freni-OSI
Translated using Weblate (German)
13f3c32 
Currently translated at 100.0% (12 of 12 strings)

Translation: field-service-12.0/field-service-12.0-fieldservice_project
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_project/de/
@marcelsavegnago @Freni-OSI
Added translation using Weblate (Portuguese (Brazil))
cf94827
@Freni-OSI
Added translation using Weblate (Spanish)
d169b1f
@Freni-OSI
Added translation using Weblate (Spanish (Chile))
c8f4936
oca-transbot and others added 14 commits May 11, 2021 11:17
@oca-transbot @Freni-OSI
Update translation files
d206bcd 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: field-service-12.0/field-service-12.0-fieldservice_project
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_project/
@fcolus @Freni-OSI
Translated using Weblate (Portuguese (Brazil))
8defcef 
Currently translated at 100.0% (13 of 13 strings)

Translation: field-service-12.0/field-service-12.0-fieldservice_project
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_project/pt_BR/
@fcolus @Freni-OSI
Translated using Weblate (Portuguese (Brazil))
60a41ef 
Currently translated at 100.0% (13 of 13 strings)

Translation: field-service-12.0/field-service-12.0-fieldservice_project
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_project/pt_BR/
@oca-transbot @Freni-OSI
Update translation files
71c60a5 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: field-service-12.0/field-service-12.0-fieldservice_project
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_project/
@baimont @Freni-OSI
[IMP] fieldservice_project: black, isort, prettier
fe8a406
@baimont @Freni-OSI
[MIG] fieldservice_project: Migration to 13.0
6deaa87
@baimont @Freni-OSI
[TESTS] fieldservice_project
fa0fce1
@oca-travis @Freni-OSI
[UPD] Update fieldservice_project.pot
cec3132
@OCA-git-bot @Freni-OSI
[UPD] README.rst
2bb0695
@Freni-OSI
[FIX] fieldservice_project: New orders do not get default project
6874908
@OCA-git-bot @Freni-OSI
[UPD] README.rst
a2a95b9
@OCA-git-bot @Freni-OSI
fieldservice_project 13.0.1.0.1
028d31c
@ibuioli @Freni-OSI
Added translation using Weblate (Spanish (Argentina))
c1187fc
@Freni-OSI
[14.0][MIG] fieldservice_project
3ed2db4
@Freni-OSI Freni-OSI force-pushed the 14_MIG_fieldservice_project branch from f6856ba to 3ed2db4 Compare May 11, 2021 06:13
@brian10048
Copy link
Contributor

Thank you @Freni-OSI!

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@fshah-initos
Copy link

It would be greate if the maintainers could merge the PR ASAP.

@fshah-initos
Copy link

It seems that PR has approved label maintainer please merge this PR.

@brian10048
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-724-by-brian10048-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 833bf41 into OCA:14.0 May 27, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 34080e3. Thanks a lot for contributing to OCA. ❤️

@smangukiya smangukiya deleted the 14_MIG_fieldservice_project branch July 23, 2021 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brian10048 brian10048 brian10048 approved these changes

@fshah-initos fshah-initos fshah-initos approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 migration ready to merge
Projects
None yet
Milestone
14.0
Development

Successfully merging this pull request may close these issues.