Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

16.0 mig l10n fr ecotaxe product #450

Closed
wants to merge 6 commits into from
Closed

16.0 mig l10n fr ecotaxe product #450

wants to merge 6 commits into from

Conversation

mourad-ehm
Copy link
Contributor

depends #448

SilvioC2C and others added 4 commits May 22, 2023 16:08
@SilvioC2C @mourad-ehm
[15.0][ADD] l10n_fr_ecotaxe_product: manage ecotax on products
3994380 
Allows managing ecotax functionalities directly on products instead of templates.
This way, a variant can have an ecotax configuration that is different from its template's configuration.
@OCA-git-bot @mourad-ehm
[UPD] README.rst
54d103f
@mourad-ehm
[UPD] Update l10n_fr_ecotaxe_product.pot
abfb461
@mourad-ehm
[IMP] l10n_fr_ecotaxe_product: pre-commit execution
e778b5d
@bealdav
Copy link
Member

bealdav commented May 23, 2023

Please @mourad-ehm could you use these intsructions to make runboat up ?
https://github.com/OCA/maintainer-tools/wiki/Use-temporary-reference%28s%29-to-another-pull-request%28s%29

@mourad-ehm mourad-ehm force-pushed the 16.0-mig-l10n_fr_ecotaxe_product branch from 1f1f45d to ddef6e7 Compare June 1, 2023 08:55
@legalsylvain legalsylvain added this to the 16.0 milestone Jun 9, 2023
@OCA OCA deleted a comment from OCA-git-bot Jun 9, 2023
@legalsylvain
Copy link
Contributor

/ocabot migration l10n_fr_ecotaxe_product

@OCA-git-bot OCA-git-bot mentioned this pull request Jun 9, 2023
Open
29 tasks
@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 22, 2023
@pfranck
Copy link

pfranck commented Nov 14, 2023

I face an issue with the test on the product, we need to activate the multi-variant option for the test

@mourad-ehm
Copy link
Contributor Author

@pfranck, The goal of this module is to manage ecotaxe on product variants. If you have no variant don't use this module

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 19, 2023
@bealdav
Copy link
Member

bealdav commented Dec 13, 2023

Finally it seems this module is no more required.

PR can be closed

@mourad-ehm
Copy link
Contributor Author

Finally it seems this module is no more required.

PR can be closed

Yes, mange of product variants was integrated in the l10n_fr_ecotaxe module

@mourad-ehm mourad-ehm closed this Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
6 participants
@mourad-ehm @bealdav @legalsylvain @pfranck @SilvioC2C @OCA-git-bot