Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][ADD] project_task_name_with_id #1158

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

AungKoKoLin1997
Copy link
Contributor

This module introduces improvements to our project task management. Now, users can locate tasks using not only the task name, but also the unique task ID. Furthermore, to make tasks easily distinguishable, each task's display name will now include its unique ID.

@qrtl

Copy link
Member

@yostashiro yostashiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and functional review. 👍

image

@yostashiro
Copy link
Member

The usage overlaps with that of project_task_code #1084, but this module is simpler for those who do not need a specific sequence rule.

@francesco-ooops
Copy link
Contributor

@AungKoKoLin1997 could you add an USAGE file?

@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 16.0-add-project_task_name_with_id branch from 8d63cae to 734e22c Compare September 7, 2023 02:05
@AungKoKoLin1997
Copy link
Contributor Author

could you add an USAGE file?

Done!

@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 16.0-add-project_task_name_with_id branch 3 times, most recently from 526c6ab to cfbcbe5 Compare September 7, 2023 03:30
@dreispt
Copy link
Member

dreispt commented Oct 10, 2023

I believe we already have a module for this need: project_task_code.
Would you consider migrating it to 16.0?

@yostashiro
Copy link
Member

@dreispt Please see this comment: #1158 (comment)

One reason I prefer this module over project_task_code is that id shows as the reference number in portal, therefore using id naturally makes the design more coherent with standard Odoo, IMO.

@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 16.0-add-project_task_name_with_id branch from cfbcbe5 to 097a925 Compare January 4, 2024 08:32
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@ivs-cetmix
Copy link
Member

@dreispt Please see this comment: #1158 (comment)

One reason I prefer this module over project_task_code is that id shows as the reference number in portal, therefore using id naturally makes the design more coherent with standard Odoo, IMO.

@yostashiro thank you for a hint!
I think one of the things TODO in the project_task_code module will be to redefine portal URLs using code instead of id.

</field>
</record>

<!-- Sharing views -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ivs-cetmix You may also want to pay attention to the sharing views in project_task_code, in case you invite external partners to collaborate on your projects.

@dreispt
Copy link
Member

dreispt commented Apr 16, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-1158-by-dreispt-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Apr 16, 2024
Signed-off-by dreispt
@OCA-git-bot
Copy link
Contributor

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-1158-by-dreispt-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@yostashiro
Copy link
Member

@AungKoKoLin1997 Can you please check if you can make project_task_code and project_task_name_with_id coexist without conflicts by making parts of the functions configurable (or just by tweaking tests)? I will have to seggregate these modules from each other otherwise.

@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 16.0-add-project_task_name_with_id branch from 7a5e751 to f39cc57 Compare April 17, 2024 04:09
Copy link
Member

@yostashiro yostashiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can you please squash commits.

@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 16.0-add-project_task_name_with_id branch from f39cc57 to e4edbf9 Compare April 17, 2024 06:01
@AungKoKoLin1997
Copy link
Contributor Author

@dreispt Can you please try to merge again?

@dreispt
Copy link
Member

dreispt commented Apr 17, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-1158-by-dreispt-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 641026e into OCA:16.0 Apr 17, 2024
5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at f33d5dc. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants