[17.0][MIG] project_template: Migration to 17.0 #1245
Conversation
|
Includes a fix for an issue I detected in the code. Based on codecov's reports, it seems like the only way to increase coverage is to add a bunch of dumb tests like "check we don't do anything if the project doesn't have a |
aisopuro
force-pushed
the
17.0-mig-project_template
branch
from
caa1079
to
1baf8a0
Compare
|
Rebased on 17.0 and re-ran pre-commit. |
|
LGTM |
|
@dreispt this one is ready for being merge :) |
|
@pedrobaeza this PR is ready too. Thank you ! |
|
/ocabot migration project_template Merging due to existing reviews: /ocabot merge nobump |
|
This PR looks fantastic, let's merge it! |
|
@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 17.0-ocabot-merge-pr-1245-by-pedrobaeza-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
|
Please rebase and check the CI failure. |
|
@aisopuro could you rebase your PR please ? |
Adding new Project Template Module [FIX] PEP8 Errors Revert "[FIX] PEP8 Errors" This reverts commit 90f9cd9. [FIX] Fixed PEP8 Formatting First upload tests showed some lint issues which this commit has the fixes for. [FIX] Fixed LINT Issue Removed unreachable code that was not needed. [FIX] RunBot Warning Fixed runbot warning about @Class to hasclass [UPD] Suggested Changes Updated based on suggested changes on other submitted modules. [UPD] Manifest and Readme Updated Manifest and Readme based on comments on other module pr's. [UPD] Suggested Changes Updated code based on suggested code changes from reviewer. [FIX] Creation Error Fixed create project error when creating project via configuration/projects menu [UPD] Menu and Bool Change Removed Template Menu (Filter option still there) and moved Bool up below name. (From reviewer suggestions) [UPD] Kanban Menu Removed button, added link to kanban menu. Start of tests [UPD] Remove project_milestone code Removed the project_milestone code and will create a separate module for that purpose.
Currently translated at 100.0% (7 of 7 strings) Translation: project-12.0/project-12.0-project_template Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_template/es/
Currently translated at 100.0% (10 of 10 strings) Translation: project-14.0/project-14.0-project_template Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_template/es_AR/
Currently translated at 100.0% (7 of 7 strings) Translation: project-14.0/project-14.0-project_template Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_template/fr/
Currently translated at 70.0% (7 of 10 strings) Translation: project-14.0/project-14.0-project_template Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_template/fr_FR/
Currently translated at 100.0% (10 of 10 strings) Translation: project-14.0/project-14.0-project_template Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_template/de/
Currently translated at 100.0% (10 of 10 strings) Translation: project-14.0/project-14.0-project_template Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_template/sv/
Since in original odoo `15.0` version project subtasks has been deleted so changes also done in this module. We don't need project subtasks anymore because odoo don't have it.
Currently translated at 100.0% (10 of 10 strings) Translation: project-16.0/project-16.0-project_template Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_template/de/
Currently translated at 100.0% (7 of 7 strings) Translation: project-16.0/project-16.0-project_template Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_template/hr/
Currently translated at 100.0% (7 of 7 strings) Translation: project-16.0/project-16.0-project_template Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_template/it/
Currently translated at 100.0% (7 of 7 strings) Translation: project-16.0/project-16.0-project_template Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_template/pt_BR/
Currently translated at 85.7% (6 of 7 strings) Translation: project-16.0/project-16.0-project_template Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_template/nl/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: project-16.0/project-16.0-project_template Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_template/
Previously, if multiple tasks in a template project had the same name, their end_date-values were not copied properly.
aisopuro
force-pushed
the
17.0-mig-project_template
branch
from
1baf8a0
to
b5aaa15
Compare
|
@aisopuro you have test that are failing. any chance that you get time to look at it ? |
|
Unlikely unfortunately. I am swamped with other work: if someone needs this I recommend making your own PR where you fix the test. The failing test is |
No description provided.