Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][ADD] project_milestone_estimated_hours #1332

Open
wants to merge 1 commit into
base: 14.0
Choose a base branch
from

Conversation

abenzbiria
Copy link

Context

The module project_milestone <https://github.com/OCA/project/tree/14.0/project_milestone>_ allows to define milestones for a project.

Multiple tasks in the project can be linked to a given milestone.

Description

Field estimated hours is displayed in form and list view of a project milestone and in tab of milestones of a project.
when a milestone is copied, value of estimated hours is copied too.

@abenzbiria
Copy link
Author

Hi Hi @aleuffre , @leemannd , @OCA/project-service-maintainers

Could you review the code of this PR, please?

Have a nice day

@TumbaoJu
Copy link

TumbaoJu commented Sep 9, 2024

@OCA/project-service-maintainers Hello! Can you please revise this PR? Thank you in advance.

@rvalyi
Copy link
Member

rvalyi commented Sep 12, 2024

nothing wrong in the code, but is it worth to add a full blown module just to add a single field? Wouldn't it be better to this field inside project_milestone directly instead?

cc @patrickrwilson @OCA/project-service-maintainers @pedrobaeza @dreispt

@rvalyi
Copy link
Member

rvalyi commented Sep 12, 2024

nothing wrong in the code, but is it worth to add a full blown module just to add a single field? Wouldn't it be better to this field inside project_milestone directly instead?

cc @patrickrwilson @OCA/project-service-maintainers @pedrobaeza @dreispt

actually after Odoo v15, project_milestone is removed from the OCA as it became a native feature. so not sure it's worth adding this module in v14. See #1268

@TumbaoJu
Copy link

TumbaoJu commented Sep 12, 2024

nothing wrong in the code, but is it worth to add a full blown module just to add a single field? Wouldn't it be better to this field inside project_milestone directly instead?
cc @patrickrwilson @OCA/project-service-maintainers @pedrobaeza @dreispt

actually after Odoo v15, project_milestone is removed from the OCA as it became a native feature. so not sure it's worth adding this module in v14. See #1268

I know that in V15, Odoo has included a feature for milestones but a lot of people use a V14 so, yes, I think it is worth it.
But thank you for your comments. It is always good to have others thoughts about it.

@pedrobaeza pedrobaeza added this to the 14.0 milestone Sep 12, 2024
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 12, 2025
@abenzbiria
Copy link
Author

Hi @pedrobaeza , @rvalyi , @leemannd , @victoralmau

Can you please mark this PR "no stale "

All tests have been confirmed, and the PR now needs approval.

Thank you

cc OCA/project-service-maintainers

@pedrobaeza pedrobaeza removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 31, 2025
@abenzbiria
Copy link
Author

Hi @OCA/project-service-maintainers

Could someone take a look and approve this PR ?

Thanks

@dreispt
Copy link
Member

dreispt commented Feb 28, 2025

I believe the directives are for the modules to not be branded by the authors.
I see a Numigi logo, and I'm not sure if the merge bot will replace it with an OCA one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants