[MIG] [17.0] project_task_personal_stage_auto_fold #1344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This module adds the behavior to change the Personal Stage of the task to the first Folded one when the task reachs an stage with "Mark as Done". If the Personal Stage is already folded, does nothing. Simplifies the behavior of closing a task, go back to Personal Stages and move it to the Pesonal Done stage. Chooses Personal Stages with the same name before Closing stages or Folded stages.
…riginal test fail By inheriting the tests of project module one of the test defined in the original module is failing, by copying the setUpClass we avoid this error.
Currently translated at 100.0% (1 of 1 strings) Translation: project-16.0/project-16.0-project_task_personal_stage_auto_fold Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_task_personal_stage_auto_fold/hr/
Currently translated at 100.0% (1 of 1 strings) Translation: project-16.0/project-16.0-project_task_personal_stage_auto_fold Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_task_personal_stage_auto_fold/it/
Currently translated at 100.0% (1 of 1 strings) Translation: project-16.0/project-16.0-project_task_personal_stage_auto_fold Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_task_personal_stage_auto_fold/pt_BR/
Currently translated at 100.0% (1 of 1 strings) Translation: project-16.0/project-16.0-project_task_personal_stage_auto_fold Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_task_personal_stage_auto_fold/es/
28 tasks
nikul-serpentcs
force-pushed
the
17_mig_project_task_personal_stage_auto_fold
branch
from
8cebca3
to
154ea2f
Compare
yvaucher
approved these changes
Sep 30, 2024
|
/ocabot migration project_task_personal_stage_auto_fold |
coleste
reviewed
Nov 12, 2024
| @@ -25,13 +30,12 @@ def _fold_personal_stage_task(self): | |||
| ) | |||
| .sorted(lambda ptt: ptt.fold, reverse=True) | |||
| ) | |||
| if not folded_stages: | |||
| return | |||
gbrito
suggested changes
Nov 13, 2024
| # Allow to find personal stage with same name as shared stage | ||
| stage_by_name = {stage.name: stage for stage in folded_stages} | ||
| # Apply best matching personal stage | ||
| default_stage = folded_stages[0] |
There was a problem hiding this comment.
This will fail when the user deleted all the folded stages, probably just return when no folded_stages are found
Suggested change
| default_stage = folded_stages[0] | |
| default_stage = folded_stages[0] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.