Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][ADD] project_attachments #1361

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

IJOL
Copy link

@IJOL IJOL commented Oct 29, 2024

Recovers a functionality of previous version, adding a button to get all attached docs associated with a project and his tasks

… version, adding a button to get all attached docs associated with a project and his tasks
@IJOL IJOL force-pushed the 16.0-project_attachments branch from 9903ea7 to 2a0e2d7 Compare October 29, 2024 14:02
@IJOL
Copy link
Author

IJOL commented Nov 11, 2024

@acysos @azmeuk @rvalyi @pedrobaeza i dont know who to ping that can take care of this.. sorry for the spam

@pedrobaeza pedrobaeza added this to the 16.0 milestone Nov 11, 2024
@pedrobaeza
Copy link
Member

For the module name, it's better to not use plurals. You can call it project_attachment_smartbutton or similar. About reviews, you can review other PRs, and ask in exchange that they review yours.

Copy link

@jorgeglez1990 jorgeglez1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally reviewed LGTM!

Copy link

@coleste coleste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, beside lack of test / coverage

from odoo import models


class ModelName(models.Model):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use the canonical name for the class, it makes it easier to search.
class Project(models.Model):

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, that was a mishap

Thanks for taking the time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants