-
-
Notifications
You must be signed in to change notification settings - Fork 803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][ADD] project_attachments #1361
base: 16.0
Are you sure you want to change the base?
Conversation
… version, adding a button to get all attached docs associated with a project and his tasks
9903ea7
to
2a0e2d7
Compare
@acysos @azmeuk @rvalyi @pedrobaeza i dont know who to ping that can take care of this.. sorry for the spam |
For the module name, it's better to not use plurals. You can call it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionally reviewed LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, beside lack of test / coverage
from odoo import models | ||
|
||
|
||
class ModelName(models.Model): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you use the canonical name for the class, it makes it easier to search.
class Project(models.Model):
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, that was a mishap
Thanks for taking the time
Recovers a functionality of previous version, adding a button to get all attached docs associated with a project and his tasks