Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][ADD] sale_project_task_recurrency: new module to Configuring Task Recurrence from the Product Form #1371

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

carlos-lopez-tecnativa
Copy link
Contributor

TT51788
@Tecnativa @pedrobaeza @victoralmau could you please review this.

@pedrobaeza pedrobaeza added this to the 17.0 milestone Nov 20, 2024
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that the date deadline preserves the hour at which the task is created. Maybe it's better to put a neutral hour like 12:00.

Copy link
Member

@victoralmau victoralmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and functional review OK.

@carlos-lopez-tecnativa carlos-lopez-tecnativa force-pushed the 17.0-sale_project_task_recurrency branch from fbc6ed4 to a994f5f Compare November 22, 2024 16:36
@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-1371-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit e4dbae4 into OCA:17.0 Nov 22, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at c8b11f0. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 17.0-sale_project_task_recurrency branch November 22, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants