Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][IMP] RMA - refactor to use procurement run #392

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

victoralmau
Copy link
Member

FWP from 15.0: #384

Extra changes:

  • Change reception_move_ids to reception_move_id
  • Add test_rma_replace_pick_ship
  • Code and method reduction to simplify logic
  • Set route_ids (in/out) from procurements

@Tecnativa TT48789

@OCA-git-bot
Copy link
Contributor

Hi @chienandalu, @pedrobaeza,
some modules you are maintaining are being modified, check this out!

@victoralmau victoralmau force-pushed the 16.0-imp-rma-TT48789 branch 4 times, most recently from 3b7197d to 28dcfd4 Compare May 31, 2024 06:31
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to extend my comments to the whole code.

@victoralmau victoralmau force-pushed the 16.0-imp-rma-TT48789 branch 2 times, most recently from d71af34 to c0974a9 Compare May 31, 2024 08:05
@pedrobaeza pedrobaeza added this to the 16.0 milestone May 31, 2024
@victoralmau victoralmau force-pushed the 16.0-imp-rma-TT48789 branch from c0974a9 to 5acf598 Compare May 31, 2024 09:45
Extra changes:
- Change reception_move_ids to reception_move_id
- Add test_rma_replace_pick_ship
- Code and method reduction to simplify logic
- Set route_ids (in/out) from procurements

Co-authored-by: Michael Tietz

TT48789
@victoralmau victoralmau force-pushed the 16.0-imp-rma-TT48789 branch from 5acf598 to 08a492c Compare June 3, 2024 09:44
@pedrobaeza pedrobaeza requested a review from chienandalu June 7, 2024 08:39
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :) Thanks!

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

/ocabot merge major

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-392-by-pedrobaeza-bump-major, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit a5f1c8d into OCA:16.0 Jun 7, 2024
5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 0675302. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants