Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG][17.0]sale_order_report_product_image #267

Open
wants to merge 3 commits into
base: 17.0
Choose a base branch
from

Conversation

ristecona
Copy link

No description provided.

Copy link

@cormaza cormaza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

</th>
<td name="td_name" position="before">
<td name="td_image">
<span
Copy link

@cormaza cormaza Jun 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should change to use new schema in odoo 17, like this sample?

<span><img t-if="line.product_id.image_128" t-att-src="image_data_uri(line.product_id.image_128)" /></span>

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i dont mind it either way

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested and doesn't work with your current migration, please check

@edy1192
Copy link

edy1192 commented Sep 18, 2024

Hi @ristecona Do you have any updates on this PR?

@ristecona
Copy link
Author

hi @edy1192 yes updated please test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants