Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] sale_triple_discount #3406

Open
wants to merge 44 commits into
base: 17.0
Choose a base branch
from
Open

[17.0][MIG] sale_triple_discount #3406

wants to merge 44 commits into from

Conversation

dalonsod
Copy link

Standard migration.

Supersedes #3157 due to inactivity.

Pending tasks:

@dalonsod dalonsod force-pushed the 17.0-mig-sale_triple_discount branch from 54893b1 to 02c0ad4 Compare November 12, 2024 16:38
This was referenced Nov 12, 2024
Open
Open
@rousseldenis
Copy link
Contributor

/ocabot migration sale_triple_discount

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Nov 14, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Nov 14, 2024
Open
82 tasks
@dalonsod dalonsod mentioned this pull request Nov 17, 2024
Open
@ferran-S73
Copy link
Contributor

@dalonsod your pre-commit commit is modifying files from another module, is this intended? I think you should this, please remove these changes

@dalonsod
Copy link
Author

@ferran-S73 these changes (for addon sale_order_general_discount) were automatically added by pre-commit execution, I didn't notice it. It suggests that sale_order_general_discount doesn't fit current pre-commit standard. I can remove it without any problem for this PR, but IMO this should be permanently fixed in that addon anyway.

@ferran-S73
Copy link
Contributor

@ferran-S73 these changes (for addon sale_order_general_discount) were automatically added by pre-commit execution, I didn't notice it. It suggests that sale_order_general_discount doesn't fit current pre-commit standard. I can remove it without any problem for this PR, but IMO this should be permanently fixed in that addon anyway.

@dalonsod I agree it should be fixed if it needs fixing but I don't think it should be done in this PR and in the same commit as the changes from the module you are migrating

@dalonsod dalonsod force-pushed the 17.0-mig-sale_triple_discount branch 2 times, most recently from cc9a8a3 to 2aed0d7 Compare November 26, 2024 17:05
@dalonsod
Copy link
Author

@ferran-S73 done

tafaRU and others added 14 commits November 29, 2024 11:35
@tafaRU @dalonsod
[ADD] sale_triple_discount
3ab2a10
@chienandalu @dalonsod
[MIG] sale_triple_discount: Migration to 10.0
6062789 
OCA Transbot updated translations from Transifex

[UPD] Update sale_triple_discount.pot
@thomaspot @dalonsod
Translated using Weblate (Nederlands (nl_NL))
a52c94d 
Currently translated at 100,0% (5 of 5 strings)

Translation: sale-workflow-10.0/sale-workflow-10.0-sale_triple_discount
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-10-0/sale-workflow-10-0-sale_triple_discount/nl_NL/
@thomaspot @dalonsod
Translated using Weblate (Dutch (nl_NL))
c1af1bf 
Currently translated at 100.0% (5 of 5 strings)

Translation: sale-workflow-10.0/sale-workflow-10.0-sale_triple_discount
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-10-0/sale-workflow-10-0-sale_triple_discount/nl_NL/
@SimoRubi @dalonsod
[FIX] sale_triple_discount: Correctly compute taxes with round_global…
bb6a27b 
…ly configuration
@SimoRubi @dalonsod
[FIX] sale_triple_discount: Store values in cache for recomputation c…
ff93966 
…onsistency

[FIX] sale_triple_discount: Invalidating the cache of specific records before recomputing price and discount

[UPD] Update sale_triple_discount.pot

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-10.0/sale-workflow-10.0-sale_triple_discount
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-10-0/sale-workflow-10-0-sale_triple_discount/
@jbaudoux @dalonsod
sale_triple_discount: Fix tax total on report: include the discount2/…
7335228 
…3 in the computation
@mpanarin @dalonsod
[IMP] 10.0 sale_triple_discount: rework discount computation
da4f1c3
@grindtildeath @dalonsod
Play onchange after invoice creation to ensure discounts are applied
17141d0
@grindtildeath @dalonsod
Fix groups on sale.order view
e90fa90 
[UPD] Update sale_triple_discount.pot
@tafaRU @dalonsod
[MIG] sale_triple_discount: Migration to 12.0
1d4f078 
[UPD] Update sale_triple_discount.pot

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-12.0/sale-workflow-12.0-sale_triple_discount
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_triple_discount/
@ps-tubtim @dalonsod
[IMP] sale_triple_discount: black, isort, prettier
ad4aec2
@ps-tubtim @dalonsod
[MIG] sale_triple_discount: Migration to 13.0
2a44ab2
@ferran-S73 @dalonsod
[IMP] sale_triple_discount: black, isort, prettier
db55e41
ferran-S73 and others added 29 commits November 29, 2024 11:35
@ferran-S73 @dalonsod
[14.0][IMP] sale_triple_discount: add disc. fields in sale report templ.
045c357
@ferran-S73 @dalonsod
[14.0] sale_triple_discount: sale_order_line_discount_validation compat.
edae596 
[UPD] Update sale_triple_discount.pot

[UPD] README.rst
@francesco-ooops @dalonsod
Translated using Weblate (Italian)
d6089d1 
Currently translated at 100.0% (11 of 11 strings)

Translation: sale-workflow-14.0/sale-workflow-14.0-sale_triple_discount
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_triple_discount/it/

[UPD] README.rst

[UPD] README.rst
@klodr @dalonsod
Translated using Weblate (French)
78a5cda 
Currently translated at 0.0% (0 of 11 strings)

Translation: sale-workflow-14.0/sale-workflow-14.0-sale_triple_discount
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_triple_discount/fr/
@manuelregidor @dalonsod
[IMP] sale_triple_discount: black, isort, prettier
88ae96a
@manuelregidor @dalonsod
[MIG]sale_triple_discount: Migration to 15.0
15ff31a 
[UPD] Update sale_triple_discount.pot

[UPD] README.rst
@OCA-git-bot @dalonsod
sale_triple_discount 15.0.1.0.1
a94fa7b 
Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-15.0/sale-workflow-15.0-sale_triple_discount
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_triple_discount/
@sbejaoui @dalonsod
[16.0][MIG] - sale_triple_discount
1799fc4
@dalonsod
[UPD] Update sale_triple_discount.pot
f7a6c1c
@OCA-git-bot @dalonsod
[UPD] README.rst
351866a
@OCA-git-bot @dalonsod
sale_triple_discount 16.0.1.0.1
20602fc
@weblate @dalonsod
Update translation files
d645162 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-16.0/sale-workflow-16.0-sale_triple_discount
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_triple_discount/
@alan196 @dalonsod
Added translation using Weblate (Spanish (Mexico))
fc62db9
@alan196 @dalonsod
Translated using Weblate (Spanish (Mexico))
06f9569 
Currently translated at 100.0% (12 of 12 strings)

Translation: sale-workflow-16.0/sale-workflow-16.0-sale_triple_discount
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_triple_discount/es_MX/
@GiuTav @dalonsod
Translated using Weblate (Italian)
164cf3d 
Currently translated at 100.0% (12 of 12 strings)

Translation: sale-workflow-16.0/sale-workflow-16.0-sale_triple_discount
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_triple_discount/it/
@Ivorra78 @dalonsod
Translated using Weblate (Spanish)
ff22fac 
Currently translated at 100.0% (12 of 12 strings)

Translation: sale-workflow-16.0/sale-workflow-16.0-sale_triple_discount
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_triple_discount/es/
@OCA-git-bot @dalonsod
[UPD] README.rst
35c7aad
@mymage @dalonsod
Translated using Weblate (Italian)
2eb067c 
Currently translated at 100.0% (12 of 12 strings)

Translation: sale-workflow-16.0/sale-workflow-16.0-sale_triple_discount
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_triple_discount/it/
@renda-dev @dalonsod
[IMP] sale_triple_discount: improve module extensibility
027ead1
@jappi00 @dalonsod
Translated using Weblate (German)
03aae6f 
Currently translated at 100.0% (12 of 12 strings)

Translation: sale-workflow-16.0/sale-workflow-16.0-sale_triple_discount
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_triple_discount/de/
@OCA-git-bot @dalonsod
[BOT] post-merge updates
4133293
@dalonsod
Translated using Weblate (Portuguese (Brazil))
d3e8824 
Currently translated at 100.0% (12 of 12 strings)

Translation: sale-workflow-16.0/sale-workflow-16.0-sale_triple_discount
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_triple_discount/pt_BR/
@lmignon @dalonsod
[FIX] sale_triple_discount: Remove call to deprecated
093a7e3 
Method 'invalidate_cache' is deprecated. To invalidate specific field's value into the cache for a recordset we must use the 'invalidate_recordset' method on the recordset itself.
@OCA-git-bot @dalonsod
[BOT] post-merge updates
dcc56ee
@lmignon @dalonsod
[IMP] sale_triple_discount: Improves perfs and consistency
208effc 
When computing the amount total on a sale.order.line, we now avoid to play with the cache since this change introduced in OCA@e3e59ba introduces a decline in performance. When the cache in invalidated, fields are flushed to the database and depending computed fields are recomputed..... This ultimately leads to temporary inconsistencies breaking others addons relaying on this one. Moreover, the method used in this original commit 'self.invalidate_cache(fnames=self._discount_fields(), ids=self.ids)' is deprecated and the use of the recommended new one lead to others side effects. The original approach is replaced by a contextual method modifying only the discount field when we need it's needed to don't break code relaying on the fact that the discount field is the total discount to apply to a line. This contextual method ensures that the original value is properly restored on exit and that it will not trigger additional recompute due to the temporary change of the discount value
@OCA-git-bot @dalonsod
[BOT] post-merge updates
8612af7
@dalonsod
[IMP] sale_triple_discount: pre-commit auto fixes
8286ad1
@dalonsod
[MIG] sale_triple_discount: Migration to 17.0
8beda8b
@dalonsod
[DON'T MERGE] test-requirements.txt
41bdc2d
@dalonsod dalonsod force-pushed the 17.0-mig-sale_triple_discount branch from 2aed0d7 to 41bdc2d Compare November 29, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferran-S73 ferran-S73 ferran-S73 approved these changes

Assignees
No one assigned
Labels
migration needs review
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.