Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] base_tier_validation_forward: Migration to 18.0 #1022

Open
wants to merge 33 commits into
base: 18.0
Choose a base branch
from

Conversation

absal-smile
Copy link

No description provided.

kittiu and others added 23 commits February 5, 2025 15:37
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-ux-16.0/server-ux-16.0-base_tier_validation_forward
Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-base_tier_validation_forward/
Currently translated at 100.0% (35 of 35 strings)

Translation: server-ux-16.0/server-ux-16.0-base_tier_validation_forward
Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-base_tier_validation_forward/es/
@absal-smile absal-smile force-pushed the 18.0-mig-base_tier_validation_forward branch from 9c69dc5 to f040cef Compare February 5, 2025 15:24
@absal-smile absal-smile force-pushed the 18.0-mig-base_tier_validation_forward branch from f040cef to 93e1ce5 Compare February 10, 2025 13:45
@absal-smile absal-smile force-pushed the 18.0-mig-base_tier_validation_forward branch 2 times, most recently from 048a449 to ca5b61d Compare February 26, 2025 10:00
@LucasTran380381
Copy link

@kittiu could you take a look ?

Copy link
Contributor

@sebalix sebalix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, small remarks

@@ -3,7 +3,7 @@
{
"name": "Base Tier Validation Forward",
"summary": "Forward option for base tiers",
"version": "17.0.1.0.0",
"version": "18.0.1.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change should be part of the migration commit (not pre-commit)

<field name="has_comment" invisible="1" />
<field name="approve_sequence" invisible="1" />
</group>
<group />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to keep this empty group?
If this is for reverse dependencies, we should probably add a comment on top explaining this (to be sure we don't delete it by mistake later on).

@kittiu
Copy link
Member

kittiu commented Mar 8, 2025

LG, small remarks

cc @Saran440 please support 🙏

Copy link
Member

@Saran440 Saran440 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional Review.
After forwarding, The description field is blank.

@absal-smile absal-smile force-pushed the 18.0-mig-base_tier_validation_forward branch 3 times, most recently from ff9fe48 to 18e00c1 Compare March 10, 2025 08:38
@absal-smile absal-smile force-pushed the 18.0-mig-base_tier_validation_forward branch from 18e00c1 to d7da44c Compare March 10, 2025 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.