-
-
Notifications
You must be signed in to change notification settings - Fork 550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0][MIG] base_tier_validation_forward: Migration to 18.0 #1022
base: 18.0
Are you sure you want to change the base?
[18.0][MIG] base_tier_validation_forward: Migration to 18.0 #1022
Conversation
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-ux-16.0/server-ux-16.0-base_tier_validation_forward Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-base_tier_validation_forward/
Currently translated at 100.0% (35 of 35 strings) Translation: server-ux-16.0/server-ux-16.0-base_tier_validation_forward Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-base_tier_validation_forward/es/
… avoid errors TT33369
9c69dc5
to
f040cef
Compare
…ed, added base user group.
f040cef
to
93e1ce5
Compare
048a449
to
ca5b61d
Compare
@kittiu could you take a look ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG, small remarks
@@ -3,7 +3,7 @@ | |||
{ | |||
"name": "Base Tier Validation Forward", | |||
"summary": "Forward option for base tiers", | |||
"version": "17.0.1.0.0", | |||
"version": "18.0.1.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change should be part of the migration commit (not pre-commit)
<field name="has_comment" invisible="1" /> | ||
<field name="approve_sequence" invisible="1" /> | ||
</group> | ||
<group /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to keep this empty group?
If this is for reverse dependencies, we should probably add a comment on top explaining this (to be sure we don't delete it by mistake later on).
cc @Saran440 please support 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional Review.
After forwarding, The description field is blank.
ff9fe48
to
18e00c1
Compare
18e00c1
to
d7da44c
Compare
No description provided.