[FIX] stock_quantity_history_location: Migrate js to OWL #282

rolandojduartem · 2023-08-18T04:49:27Z

This commit solves the error
"Non loaded module
stock_quantity_history_location.InventoryReportListController" because
the dependency stock.InventoryReportListController was missed. The
dependency from stock was migrated to OWL [1], so it is inherited using the
OWL to preserve the behavior.

References:

[1] odoo/odoo@ec0b1005

rolandojduartem · 2023-08-18T04:49:41Z

This is in development phase

OCA-git-bot · 2023-08-18T06:06:52Z

Hi @luisg123v,
some modules you are maintaining are being modified, check this out!

rolandojduartem · 2023-08-19T20:49:56Z

Hi, @luisg123v, @imanie383 and @desdelinux, please, could you review this PR? Do you know anything about the lint in the pre-commit?

luisg123v · 2023-08-20T17:32:24Z

Hi @sebasdrk17,

Could you review, please?

luisg123v · 2023-08-20T17:32:48Z

stock_quantity_history_location/__manifest__.py

+            "stock_quantity_history_location/static/src/components"
+            "/inventory_report/inventory_report.js",
+            "stock_quantity_history_location/static/src/components/"
+            "inventory_report//inventory_report.xml",


Extra slash

luisg123v · 2023-08-20T17:34:22Z

stock_quantity_history_location/static/src/components/inventory_report/inventory_report.xml

@@ -0,0 +1,26 @@
+<?xml version="1.0" encoding="UTF-8" ?>
+<templates>


I meant ID:

Suggested change

<templates>

<templates id="template" xml:space="preserve">

luisg123v · 2023-08-20T17:36:58Z

stock_quantity_history_location/static/src/components/inventory_report/inventory_report.xml

+<templates>
+    <t t-inherit="stock.InventoryReport.Buttons" t-inherit-mode="extension" owl="1">
+        <xpath expr="//button[contains(@t-if, 'stock.quant')]" position="attributes">
+            <attribute name="t-if" add="and !this.multi_location" separator=" " />


There's no safe way to add conditions to an attribute, as order is not guaranteed

I'd suggest creating a <t t-if element and moving button there, and inserting the new button just after that element using t-else

imanie383 · 2023-08-21T15:55:26Z

stock_quantity_history_location/__manifest__.py

-            "stock_quantity_history_location/static/src/xml/inventory_report.xml",
+            "stock_quantity_history_location/static/src/components"
+            "/inventory_report/inventory_report.js",
+            "stock_quantity_history_location/static/src/components/"


you are not importing any files in L22

It was importing the file.

@imanie383 to clarify, this is a multiline string, next line contains file name.

Up to you

you could just use a shortpath

stock_quantity_history_location/static/src/**/*.xml

example:

I know, but @luisg123v prefers explicit file paths when there are few files.

imanie383 · 2023-08-21T16:11:59Z

stock_quantity_history_location/static/src/components/inventory_report/inventory_report.js

+        this._super(...arguments);
+        this.multi_location = false;
+        onWillStart(async () => {
+            this.multi_location = await session.user_has_group(


https://www.odoo.com/documentation/16.0/developer/reference/frontend/services.html#using-a-service

rolandojduartem · 2023-08-21T18:00:44Z

Hi, @luisg123v and @imanie383, I applied your suggestions.

sebasdrk17 · 2023-08-21T18:04:12Z

@luisg123v Am I still needed here? I've seen that @imanie383 has already review

luisg123v · 2023-08-21T18:17:16Z

@luisg123v Am I still needed here? I've seen that @imanie383 has already review

@sebasdrk17 maybe not as needed anymore, but any comment is welcomed anyway.

luisg123v · 2023-08-21T18:27:48Z

stock_quantity_history_location/static/src/components/inventory_report/inventory_report.xml

+<?xml version="1.0" encoding="UTF-8" ?>
+<templates id="template" xml:space="preserve">
+    <t t-inherit="stock.InventoryReport.Buttons" t-inherit-mode="extension" owl="1">
+        <xpath expr="(//div/*)[last()]" position="after">


AFAIK this is inserting elements at the end, even after the "Appli All" button.

Maybe what you need is to place this before the "Apply All" button, by filtering by t-on-click="onClickApplyAll".

luisg123v · 2023-08-21T18:29:49Z

stock_quantity_history_location/static/src/components/inventory_report/inventory_report.xml

+                            !props.context.inventory_mode
+                            or props.context.inventory_report_mode
+                        )
+                        and !props.context.no_at_date


Add an ID to this button, so if we (or anybody else) migrate the module stock_account_quantity_history_location, xpaths are simpler

imanie383 · 2023-08-21T18:33:19Z

stock_quantity_history_location/static/src/components/inventory_report/inventory_report.js

@@ -0,0 +1,17 @@
+/** @odoo-module */


Suggested change

/** @odoo-module */

/** @odoo-module **/

rolandojduartem · 2023-08-21T19:09:18Z

Hi, @luisg123v and @imanie383, I applied your suggestions.

rolandojduartem · 2023-08-21T21:57:15Z

Hi, @luisg123v and @imanie383, could you review this PR again? CI is green now

imanie383 · 2023-08-21T22:35:11Z

stock_quantity_history_location/static/src/components/inventory_report/inventory_report.xml

+            <t t-else="" name="has_not_multi_location" />
+        </button>
+        <t name="has_not_multi_location" position="inside">
+            <xpath expr="//button[contains(@t-if, 'stock.quant')]" position="move" />


Wait, I'm not sure why you need another button if your button is exactly the same as the original button(if and click-method)

Actually, hasclass('o_button_at_date') is more ambiguous because stock_account add another button with that class, actually using the model is more specific for every button. What do you think? (This module will work together with stock_account_quantity_history_location if stock_account_quantity_history_location is migrated).

I agree with @rolandojduartem, current filter is preferred to using class.

Regarding this:

Wait, I'm not sure why you need another button if your button is exactly the same as the original button(if and click-method)

Because the text is different and there's no way to change or hide current text.

you can use a t-out like

<button t-out="'demo'">imanie</button>

that overwrites the inner text

imanie383 · 2023-08-21T23:28:18Z

stock_quantity_history_location/static/src/components/inventory_report/inventory_report.xml

+<templates id="template" xml:space="preserve">
+    <t t-inherit="stock.InventoryReport.Buttons" t-inherit-mode="extension" owl="1">
+        <button t-on-click="onClickApplyAll" position="before">
+            <t t-if="this.multi_location" name="has_multi_location">


Suggested change

<t t-if="this.multi_location" name="has_multi_location">

<t t-if="multi_location" name="has_multi_location">

This commit solves the error "Non loaded module stock_quantity_history_location.InventoryReportListController" because the dependency stock.InventoryReportListController was missed. The dependency from stock was migrated to OWL [1], so it is inherited using the OWL to preserve the behavior. References: - [1] odoo/odoo@ec0b1005

rolandojduartem · 2023-08-22T20:46:59Z

Hi, @luisg123v and @imanie383, what do you think now? I could not make the groups attribute works for this inheritance, it would be great to remove the js file

luisg123v

LGTM 👍

/ocabot merge nobump

Not increasing version because this change is already increasing it.

OCA-git-bot · 2023-08-22T21:17:45Z

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-282-by-luisg123v-bump-nobump, awaiting test results.

OCA-git-bot · 2023-08-22T21:20:36Z

Congratulations, your PR was merged at 928abb2. Thanks a lot for contributing to OCA. ❤️

rolandojduartem force-pushed the 16.0-stock_quantity_history_location-migrate_to_owl-rolando branch 3 times, most recently from 77b0c2c to 9eab428 Compare August 19, 2023 20:48

luisg123v suggested changes Aug 20, 2023

View reviewed changes

imanie383 suggested changes Aug 21, 2023

View reviewed changes

rolandojduartem force-pushed the 16.0-stock_quantity_history_location-migrate_to_owl-rolando branch from 9eab428 to c19fc50 Compare August 21, 2023 17:57

luisg123v suggested changes Aug 21, 2023

View reviewed changes

imanie383 reviewed Aug 21, 2023

View reviewed changes

rolandojduartem force-pushed the 16.0-stock_quantity_history_location-migrate_to_owl-rolando branch 2 times, most recently from b89296a to 3226a7c Compare August 21, 2023 19:07

imanie383 force-pushed the 16.0-stock_quantity_history_location-migrate_to_owl-rolando branch from 2132463 to dd88aeb Compare August 21, 2023 19:28

rolandojduartem force-pushed the 16.0-stock_quantity_history_location-migrate_to_owl-rolando branch 2 times, most recently from 3226a7c to 8325609 Compare August 21, 2023 19:34

imanie383 reviewed Aug 21, 2023

View reviewed changes

rolandojduartem force-pushed the 16.0-stock_quantity_history_location-migrate_to_owl-rolando branch from 8325609 to 5ae2895 Compare August 22, 2023 20:41

luisg123v approved these changes Aug 22, 2023

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label Aug 22, 2023

OCA-git-bot merged commit db10002 into OCA:16.0 Aug 22, 2023
6 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Aug 22, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FIX] stock_quantity_history_location: Migrate js to OWL #282

[FIX] stock_quantity_history_location: Migrate js to OWL #282

rolandojduartem commented Aug 18, 2023 •

edited

Loading

rolandojduartem commented Aug 18, 2023

OCA-git-bot commented Aug 18, 2023

rolandojduartem commented Aug 19, 2023

luisg123v commented Aug 20, 2023

luisg123v Aug 20, 2023

luisg123v Aug 20, 2023

luisg123v Aug 21, 2023

luisg123v Aug 20, 2023

imanie383 Aug 21, 2023 •

edited

Loading

rolandojduartem Aug 21, 2023

luisg123v Aug 21, 2023

sebasdrk17 Aug 21, 2023

rolandojduartem Aug 21, 2023

imanie383 Aug 21, 2023

rolandojduartem commented Aug 21, 2023

sebasdrk17 commented Aug 21, 2023

luisg123v commented Aug 21, 2023

luisg123v Aug 21, 2023

luisg123v Aug 21, 2023

imanie383 Aug 21, 2023

rolandojduartem commented Aug 21, 2023

rolandojduartem commented Aug 21, 2023

imanie383 Aug 21, 2023 •

edited

Loading

imanie383 Aug 21, 2023

rolandojduartem Aug 21, 2023

luisg123v Aug 21, 2023

imanie383 Aug 21, 2023 •

edited

Loading

imanie383 Aug 21, 2023 •

edited

Loading

rolandojduartem commented Aug 22, 2023

luisg123v left a comment

OCA-git-bot commented Aug 22, 2023

OCA-git-bot commented Aug 22, 2023

		@@ -0,0 +1,26 @@
		<?xml version="1.0" encoding="UTF-8" ?>
		<templates>

	<t t-if="this.multi_location" name="has_multi_location">
	<t t-if="multi_location" name="has_multi_location">

[FIX] stock_quantity_history_location: Migrate js to OWL #282

[FIX] stock_quantity_history_location: Migrate js to OWL #282

Conversation

rolandojduartem commented Aug 18, 2023 • edited Loading

rolandojduartem commented Aug 18, 2023

OCA-git-bot commented Aug 18, 2023

rolandojduartem commented Aug 19, 2023

luisg123v commented Aug 20, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

imanie383 Aug 21, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rolandojduartem commented Aug 21, 2023

sebasdrk17 commented Aug 21, 2023

luisg123v commented Aug 21, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rolandojduartem commented Aug 21, 2023

rolandojduartem commented Aug 21, 2023

imanie383 Aug 21, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

imanie383 Aug 21, 2023 • edited Loading

Choose a reason for hiding this comment

imanie383 Aug 21, 2023 • edited Loading

Choose a reason for hiding this comment

rolandojduartem commented Aug 22, 2023

luisg123v left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Aug 22, 2023

OCA-git-bot commented Aug 22, 2023

rolandojduartem commented Aug 18, 2023 •

edited

Loading

imanie383 Aug 21, 2023 •

edited

Loading

imanie383 Aug 21, 2023 •

edited

Loading

imanie383 Aug 21, 2023 •

edited

Loading

imanie383 Aug 21, 2023 •

edited

Loading