[14.0][MIG] stock_inventory_valuation_report #292

solo4games · 2023-10-17T10:18:21Z

No description provided.

francesco-ooops

Functional ok!

This migration was done in order to make use of module report_async to generate report in case system takes a long time to provide inventory valuation

geomer198

LGTM!

geomer198 · 2023-10-20T20:15:47Z

stock_inventory_valuation_report/reports/stock_inventory_valuation_report.py

+        self.ensure_one()
+        action = (
+            report_type == "xlsx"
+            and self.env.ref(


Could you add raise_if_not_found=False for ref function.

geomer198 · 2023-10-20T20:25:03Z

stock_inventory_valuation_report/reports/stock_inventory_valuation_report.py

+        products = (
+            self.env["product.product"]
+            .with_context(
+                dict(to_date=self.date, company_owned=True, create=False, edit=False)


You can do without dict.
with_context(to_date=self.date, company_owned=True, create=False, edit=False)

francesco-ooops · 2023-10-24T13:32:04Z

@OCA/logistics-maintainers good for merge?

francesco-ooops · 2023-10-27T08:36:14Z

@rafaelbn looks good to you? :)

rafaelbn · 2023-10-28T08:46:36Z

/ocabot migration stock_inventory_valuation_report

rafaelbn · 2023-10-28T08:47:49Z

@ps-tubtim could you please review o ping a colleage? this is a Ecosoft original module 😄 Thank you!

francesco-ooops · 2023-10-31T09:48:58Z

@ps-tubtim gentle reminder :)

francesco-ooops · 2023-11-07T08:27:18Z

@simahawk could we go? :)

francesco-ooops · 2023-11-14T09:03:55Z

@sebalix could you take a look at this? thank you!

francesco-ooops · 2023-11-21T09:47:58Z

@OCA/logistics-maintainers gentle reminder

rousseldenis · 2023-11-21T10:02:08Z

stock_inventory_valuation_report/readme/CONTRIBUTORS.rst

@@ -1 +1,3 @@
 * Pimolnat Suntian <[email protected]>
+* Ooops404 <https://ooops404.com>


Please put contributors' names. You can add a company as title.

rousseldenis · 2023-11-21T10:09:04Z

stock_inventory_valuation_report/reports/stock_inventory_valuation_report.py

                "cost_method": product.cost_method,
            }
-            if product.qty_at_date != 0:
+            if product.qty_available != 0:


@solo4games Shouldn't it be 'quantity_svl' field instead ? See stock_account/models/product.py

I am not sure about that, because, when I did it, one of the tests were failed because it did not pass that if condition, so I can not said that I am right

This condition should be dropped as it is already part of the search on products

OCA-git-bot · 2023-11-21T10:09:11Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

jbaudoux

Bugs are not related to migration but sill the report seems wrong

jbaudoux · 2023-11-23T07:11:24Z

stock_inventory_valuation_report/reports/stock_inventory_valuation_report.py

+        )
+        ReportLine = self.env["stock.inventory.valuation.view"]
+        for product in products:
+            standard_price = product.standard_price


This looks wrong. This is not the price at date. It should be value_svl

jbaudoux · 2023-11-23T07:11:27Z

stock_inventory_valuation_report/reports/stock_inventory_valuation_report.py

+                "name": product.name,
+                "reference": product.default_code,
+                "barcode": product.barcode,
+                "qty_at_date": product.qty_available,


should also likely be quantity_svl

Thank you for your feedback
You are right
I fix it, please check again

jbaudoux · 2023-11-23T07:12:22Z

stock_inventory_valuation_report/reports/stock_inventory_valuation_report.py

                "cost_method": product.cost_method,
            }
-            if product.qty_at_date != 0:
+            if product.qty_available != 0:


This condition should be dropped as it is already part of the search on products

francesco-ooops · 2023-11-24T17:43:21Z

@jbaudoux good for you?

aleuffre

Partial code review, Still some issues IMO

aleuffre · 2023-12-18T10:42:26Z

stock_inventory_valuation_report/security/ir.model.access.csv

+access_report_stock_inventory_valuation_report,report.stock.inventory.valuation.report,model_report_stock_inventory_valuation_report,base.group_user,1,1,1,1
+access_stock_inventory_valuation_view,stock_inventory_valuation_view,model_stock_inventory_valuation_view,base.group_user,1,1,1,1
+access_report_s_i_v_r_report_stock_inventory_valuation_report_xlsx,report.s_i_v_r.report_stock_inventory_valuation_report_xlsx,model_report_s_i_v_r_report_stock_inventory_valuation_report_xlsx,base.group_user,1,1,1,1


issue: IMO base.group_user is too broad. At the very least, we should restrict access to stock.group_stock_user

thanks, I'll fix it

aleuffre · 2023-12-18T10:48:26Z

stock_inventory_valuation_report/wizard/stock_quantity_history.py

+    compute_at_date = fields.Selection(
+        [("0", "Current Inventory"), ("1", "At a Specific Date")],
+        string="Compute",
+        help="Choose to analyze the current inventory or from a specific date in the past.",
+        default="0",
+    )
+    inventory_datetime = fields.Datetime(
+        "Inventory at Date",
+        help="Choose a date to get the inventory at that date",
+        default=fields.Datetime.now,
+    )


issue: I still don't understand why there's a need to re-declare these fields instead of using the fields that already exist.

Cf. the module on v12 that we are porting to v14: https://github.com/OCA/stock-logistics-reporting/blob/12.0/stock_inventory_valuation_report/wizard/stock_quantity_history.py

aleuffre · 2023-12-18T10:49:59Z

stock_inventory_valuation_report/wizard/stock_quantity_history.py

+        default=fields.Datetime.now,
+    )
+
+    def open_table(self):


issue: same as above - why is this function being declared again (from Odoo v12) instead of using open_at_date which is available in Odoo v14?

Please look at the module on v12 https://github.com/OCA/stock-logistics-reporting/blob/12.0/stock_inventory_valuation_report/wizard/stock_quantity_history.py
and the base wizard in stock and stock_account
https://github.com/OCA/OCB/blob/14.0/addons/stock/wizard/stock_quantity_history.py#L8
https://github.com/OCA/OCB/blob/14.0/addons/stock_account/wizard/stock_quantity_history.py

dessanhemrayev · 2023-12-18T19:54:14Z

@francesco-ooops , please do a functional review)

francesco-ooops · 2023-12-20T15:50:05Z

@francesco-ooops , please do a functional review)

@dessanhemrayev PDF report don't seem to work on runboat

dessanhemrayev · 2023-12-20T19:37:58Z

@francesco-ooops , please do a functional review)

@dessanhemrayev PDF report don't seem to work on runboat

@francesco-ooops, I fixed it

dessanhemrayev · 2023-12-28T17:42:39Z

@aleuffre, please check)

francesco-ooops · 2024-01-02T09:30:56Z

@dessanhemrayev if that's ok for you we can take over this task, thanks for the work done so far!

francesco-ooops · 2024-02-12T11:59:52Z

@rousseldenis this can be closed

francesco-ooops approved these changes Oct 19, 2023

View reviewed changes

geomer198 approved these changes Oct 20, 2023

View reviewed changes

geomer198 reviewed Oct 20, 2023

View reviewed changes

solo4games force-pushed the 14.0-MIG-stock_inventory_valuation_report branch 2 times, most recently from 734f7a2 to 26b2d15 Compare October 22, 2023 22:19

OCA-git-bot added this to the 14.0 milestone Oct 28, 2023

OCA-git-bot mentioned this pull request Feb 13, 2023

Migration to version 14.0 #119

Open

9 tasks

rafaelbn added needs review migration labels Oct 28, 2023

rousseldenis reviewed Nov 21, 2023

View reviewed changes

OCA-git-bot added the approved label Nov 21, 2023

rousseldenis reviewed Nov 21, 2023

View reviewed changes

OCA-git-bot added the ready to merge label Nov 21, 2023

solo4games force-pushed the 14.0-MIG-stock_inventory_valuation_report branch from 26b2d15 to 22c87ba Compare November 22, 2023 18:59

jbaudoux reviewed Nov 23, 2023

View reviewed changes

dessanhemrayev force-pushed the 14.0-MIG-stock_inventory_valuation_report branch from a617a3b to baafd54 Compare November 24, 2023 01:10

dessanhemrayev force-pushed the 14.0-MIG-stock_inventory_valuation_report branch 4 times, most recently from d3c3736 to 2203fb2 Compare November 28, 2023 09:54

OCA-git-bot removed approved ready to merge labels Dec 11, 2023

dessanhemrayev force-pushed the 14.0-MIG-stock_inventory_valuation_report branch 13 times, most recently from a01bcb7 to acc4e99 Compare December 14, 2023 20:09

aleuffre suggested changes Dec 18, 2023

View reviewed changes

[MIG] stock_inventory_valuation_report: Migration to 14.0

6b19bc7

dessanhemrayev force-pushed the 14.0-MIG-stock_inventory_valuation_report branch from acc4e99 to 6b19bc7 Compare December 18, 2023 19:35

[FIX] stock_inventory_valuation_report: remove extra methods

ec7f098

dessanhemrayev force-pushed the 14.0-MIG-stock_inventory_valuation_report branch from fd55d02 to ec7f098 Compare December 20, 2023 19:31

aleuffre mentioned this pull request Jan 2, 2024

[14.0][MIG] stock_inventory_valuation_report #299

Merged

rousseldenis closed this Feb 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[14.0][MIG] stock_inventory_valuation_report #292

[14.0][MIG] stock_inventory_valuation_report #292

solo4games commented Oct 17, 2023

francesco-ooops left a comment •

edited

Loading

geomer198 left a comment

geomer198 Oct 20, 2023

geomer198 Oct 20, 2023

francesco-ooops commented Oct 24, 2023

francesco-ooops commented Oct 27, 2023

rafaelbn commented Oct 28, 2023

rafaelbn commented Oct 28, 2023

francesco-ooops commented Oct 31, 2023

francesco-ooops commented Nov 7, 2023

francesco-ooops commented Nov 14, 2023

francesco-ooops commented Nov 21, 2023

rousseldenis Nov 21, 2023

rousseldenis Nov 21, 2023 •

edited

Loading

solo4games Nov 22, 2023

jbaudoux Nov 23, 2023

OCA-git-bot commented Nov 21, 2023

jbaudoux left a comment

jbaudoux Nov 23, 2023

jbaudoux Nov 23, 2023

dessanhemrayev Nov 24, 2023

jbaudoux Nov 23, 2023

francesco-ooops commented Nov 24, 2023

aleuffre left a comment •

edited

Loading

aleuffre Dec 18, 2023

dessanhemrayev Dec 18, 2023

aleuffre Dec 18, 2023

aleuffre Dec 18, 2023

dessanhemrayev commented Dec 18, 2023 •

edited

Loading

francesco-ooops commented Dec 20, 2023

dessanhemrayev commented Dec 20, 2023 •

edited

Loading

dessanhemrayev commented Dec 28, 2023

francesco-ooops commented Jan 2, 2024

francesco-ooops commented Feb 12, 2024

		@@ -1 +1,3 @@
		* Pimolnat Suntian <[email protected]>
		* Ooops404 <https://ooops404.com>

[14.0][MIG] stock_inventory_valuation_report #292

[14.0][MIG] stock_inventory_valuation_report #292

Conversation

solo4games commented Oct 17, 2023

francesco-ooops left a comment • edited Loading

Choose a reason for hiding this comment

geomer198 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

francesco-ooops commented Oct 24, 2023

francesco-ooops commented Oct 27, 2023

rafaelbn commented Oct 28, 2023

rafaelbn commented Oct 28, 2023

francesco-ooops commented Oct 31, 2023

francesco-ooops commented Nov 7, 2023

francesco-ooops commented Nov 14, 2023

francesco-ooops commented Nov 21, 2023

Choose a reason for hiding this comment

rousseldenis Nov 21, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

OCA-git-bot commented Nov 21, 2023

jbaudoux left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

francesco-ooops commented Nov 24, 2023

aleuffre left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dessanhemrayev commented Dec 18, 2023 • edited Loading

francesco-ooops commented Dec 20, 2023

dessanhemrayev commented Dec 20, 2023 • edited Loading

dessanhemrayev commented Dec 28, 2023

francesco-ooops commented Jan 2, 2024

francesco-ooops commented Feb 12, 2024

francesco-ooops left a comment •

edited

Loading

rousseldenis Nov 21, 2023 •

edited

Loading

aleuffre left a comment •

edited

Loading

dessanhemrayev commented Dec 18, 2023 •

edited

Loading

dessanhemrayev commented Dec 20, 2023 •

edited

Loading