[FIX]stock_picking_report_valued: Fix #305. Avoid error when no sale line is linked to move line. #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierjcf
force-pushed
the
16.0-fix-stock-picking-report-valued
branch
from
7c99c75 to
61881b5
Compare
pedrobaeza
reviewed
Jun 27, 2024
Comment on lines
52
to
56
| line.currency_id = ( | ||
| line.sale_line.currency_id.id | ||
| if line.sale_line | ||
| else line.company_id.currency_id.id | ||
| ) |
There was a problem hiding this comment.
Suggested change
| line.currency_id = ( | |
| line.sale_line.currency_id.id | |
| if line.sale_line | |
| else line.company_id.currency_id.id | |
| ) | |
| line.currency_id = ( | |
| line.sale_line.currency_id.id | |
| or line.company_id.currency_id.id | |
| ) |
javierjcf
force-pushed
the
16.0-fix-stock-picking-report-valued
branch
from
61881b5 to
6b22909
Compare
pedrobaeza
reviewed
Jun 27, 2024
| related="sale_line.currency_id", readonly=True, string="Sale Currency" | ||
| comodel_name='res.currency', | ||
| compute="_compute_sale_currency_id", | ||
| readonly=True, |
There was a problem hiding this comment.
computed fields are readonly by default.
javierjcf
force-pushed
the
16.0-fix-stock-picking-report-valued
branch
3 times, most recently
from
63adde2 to
527c261
Compare
…om company if not sale line related
javierjcf
force-pushed
the
16.0-fix-stock-picking-report-valued
branch
from
527c261 to
e692596
Compare
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue #305 is due to the Subtotal and Total fields being of type Monetary. These fields require the currency_id field to be correctly calculated. Currently, the currency_id field is a related field from the sales line, which may not exist. This PR changes the field from related to computed, and if there is no associated sales line, it takes the currency from the company.