Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][ADD] stock_account_valuation_discrepancy_adjust #337

Conversation

AaronHForgeFlow
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow commented Sep 4, 2024

Trying to add a module to fix discrepancies in the Dual inventory valuation report. The first attempt was this one: #175

This version is much simpler because the customer don't want to have a separate menu, I think it is not needed. The idea is they run the current report, and then the user uses the filter "Valuation Discrepancy" in order to see the products with discrepancies and apply the adjustments.

If users wants to do the adjustment in the past then they have to generate the Dual Inventory Valuation report in the past.

Added a small test also

Added the option to create a single journal entry if wanted.

cc @ForgeFlow

@AaronHForgeFlow AaronHForgeFlow force-pushed the 16.0-add-stock_account_valaution_report_discrepancy_adjust branch from 14f9eed to 63f9129 Compare September 9, 2024 15:31
@AaronHForgeFlow
Copy link
Contributor Author

In order to do a functional review you can do the following:

Create a storable product with standard cost .Ensure the product category is real time valuated:
2024-09-12_16-52_1

Update the stock on hand:

2024-09-12_16-56

Update the stock on hand again, and apply the changes:

2024-09-12_17-02

Unpost a journal entry created by one of the stock changes (search for "Product Quantity Updated"):

2024-09-12_17-02_1

Run the Dual Inventory Valuation report (in Inventory / Reporting / Dual Inventory Valuation) (Please notice the report is already in OCA, here I am adding the wizard only). Open the wizard for the product:

2024-09-12_17-03

Choose the counterpart accounts and click on "Make Adjustment":

2024-09-12_17-04

Run the report "Dual Inventory Valuation" again. The product should show no discrepancy now :)

You can check the journal entry created by looking at the journal entry with reference "Adjust for Stock Valuation Discrepancy"

Copy link

@LauraCForgeFlow LauraCForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@MiquelRForgeFlow MiquelRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AaronHForgeFlow AaronHForgeFlow force-pushed the 16.0-add-stock_account_valaution_report_discrepancy_adjust branch from 36dc1b1 to 0208a15 Compare November 11, 2024 10:24
…ds from the wizard as long they are slow computed an unnecessary to take a decision
@AaronHForgeFlow AaronHForgeFlow force-pushed the 16.0-add-stock_account_valaution_report_discrepancy_adjust branch from 6e22b54 to 6e34192 Compare November 29, 2024 09:07
@LoisRForgeFlow
Copy link

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-337-by-LoisRForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit c503641 into OCA:16.0 Nov 29, 2024
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at a7e1b88. Thanks a lot for contributing to OCA. ❤️

@MiquelRForgeFlow MiquelRForgeFlow deleted the 16.0-add-stock_account_valaution_report_discrepancy_adjust branch November 29, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants