Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][MIG] product_route_profile #1775

Open
wants to merge 18 commits into
base: 15.0
Choose a base branch
from
Open

[15.0][MIG] product_route_profile #1775

wants to merge 18 commits into from

Conversation

bosd
Copy link
Contributor

@bosd bosd commented Jun 23, 2023 •
edited
Loading

Standard migration.

@bosd bosd force-pushed the 15.0-mig-product_route_profile branch 3 times, most recently from 51944b5 to 8c505e3 Compare June 23, 2023 18:21
@bosd bosd force-pushed the 15.0-mig-product_route_profile branch 2 times, most recently from 02a7d37 to ba6b877 Compare August 12, 2023 21:43
@bosd bosd force-pushed the 15.0-mig-product_route_profile branch 5 times, most recently from ab4e002 to 95773a9 Compare October 31, 2023 19:25
@bosd
Copy link
Contributor Author

bosd commented Oct 31, 2023

Generated the icon with command:

oca-gen-addon-icon --addon-dir=. --format png --icon-set-params "fa fa-route" --icon-extra='{"fa fa-box fa-lg": {"position": "absolute", "top": "100px", "left": "5px", "font-size": "28px"}}' --icon-color yellow

@bosd bosd marked this pull request as ready for review October 31, 2023 19:54
Kev-Roche and others added 17 commits January 13, 2024 17:31
@Kev-Roche @bosd
[ADD] module: product_route_profile
bd47ee9
@bosd
[UPD] Update product_route_profile.pot
3a18b5b
@OCA-git-bot @bosd
[UPD] README.rst
cace422
@OCA-git-bot @bosd
[ADD] icon.png
36926c7
@OCA-git-bot @bosd
product_route_profile 14.0.1.0.1
fe550fd
@awisky @bosd
[FIX] product_route_profile _inverse_route_ids store selected route_p…
0fd9234 
…rofile_id
@OCA-git-bot @bosd
product_route_profile 14.0.1.0.2
d6a09e3
@bosd
Added translation using Weblate (Dutch)
54d8c3c
@OCA-git-bot @bosd
[UPD] README.rst
3507a64
@weblate @bosd
Update translation files
4ae3c68 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-warehouse-14.0/stock-logistics-warehouse-14.0-product_route_profile
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-14-0/stock-logistics-warehouse-14-0-product_route_profile/
@etobella @bosd
*: Fix pylint
602cbb6
@bosd
[UPD] Update product_route_profile.pot
0f9a9a2
@OCA-git-bot @bosd
[BOT] post-merge updates
e66cb5b
@weblate @bosd
Update translation files
ca3ec30 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-warehouse-14.0/stock-logistics-warehouse-14.0-product_route_profile
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-14-0/stock-logistics-warehouse-14-0-product_route_profile/
@bosd
[IMP] product_route_profile: pre-commit execution
54d3390
@bosd
[MIG] product_route_profile: Migration to 15.0
e88af8c
@bosd
[IMP] product_route_profile: add custom icon
c0cbd2e 
generated with oca icon generator.
@bosd bosd force-pushed the 15.0-mig-product_route_profile branch from 5e90c9f to c0cbd2e Compare January 13, 2024 16:31
@bosd
Copy link
Contributor Author

bosd commented Jan 13, 2024

@pedrobaeza pre-commit was broken here..
But all good now. 👍

@pedrobaeza
Copy link
Member

/ocabot migration product_route_profile

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Jan 13, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Jan 13, 2024
Open
80 tasks
@bosd
Copy link
Contributor Author

bosd commented Feb 2, 2024

@francesco-ooops Can you please review?

francesco-ooops
francesco-ooops reviewed Feb 5, 2024
View reviewed changes
Copy link
Contributor

@francesco-ooops francesco-ooops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bosd sorry but I don't understand well what this module does. I can only see a "Route Profile" menu where I can create a record and assign a name and nothing else

@bosd
Copy link
Contributor Author

bosd commented Apr 25, 2024 •
edited
Loading

Hi @bosd sorry but I don't understand well what this module does. I can only see a "Route Profile" menu where I can create a record and assign a name and nothing else

After you created a route profile, It can be assigned to a product.
It is usefull to have a products route configured with one click.
Specifically when multiple routes can be applied to a product.

e.g. with one click, the correct values are set according to the defined route_profile.
It can be set as mandatory. to prevent users erros selecting the wron routes.

@StefanRijnhart StefanRijnhart mentioned this pull request Jul 4, 2024
Merged
StefanRijnhart
StefanRijnhart approved these changes Jul 4, 2024
View reviewed changes
Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Using this as the basis of the migration to 17.0 at #2097

rousseldenis
rousseldenis reviewed Jul 5, 2024
View reviewed changes
product_route_profile/models/product_template.py
@@ -28,7 +28,7 @@ class ProductTemplate(models.Model):
@api.depends("route_profile_id", "force_route_profile_id")
@api.depends_context("company")
def _compute_route_ids(self):
for rec in self:
for rec in self.sudo():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bosd Why is this needed ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it was needed to pass the tests.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bosd I still need an answer on this as just putting this for tests is not wanted.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question. I don't remember, it has been a while :)
Maybe better to do functional test it without this. To see if it only is relevant for the tests. Or also required to achieve the functionality.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that different routes may apply depending on the current company, it might be the case that there are route profiles (with an empty company_id) that provide routes for different companies. In that case it makes sense to escalate privileges when copying routes so that routes are copied even if the user does not have access to the all the companies that the routes belong to.

Dranyel-Bosd
Dranyel-Bosd approved these changes Oct 17, 2024
View reviewed changes
Copy link

@Dranyel-Bosd Dranyel-Bosd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@bosd
Copy link
Contributor Author

bosd commented Jan 18, 2025

Can we get a merge 🙏

@StefanRijnhart
Copy link
Member

@francesco-ooops @rousseldenis Is this PR ok for you now?

@francesco-ooops
Copy link
Contributor

Hi @bosd sorry but I don't understand well what this module does. I can only see a "Route Profile" menu where I can create a record and assign a name and nothing else

After you created a route profile, It can be assigned to a product. It is usefull to have a products route configured with one click. Specifically when multiple routes can be applied to a product.

e.g. with one click, the correct values are set according to the defined route_profile. It can be set as mandatory. to prevent users erros selecting the wron routes.

@bosd great, this should go in the docs then :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francesco-ooops francesco-ooops francesco-ooops left review comments

@rousseldenis rousseldenis rousseldenis left review comments

@StefanRijnhart StefanRijnhart StefanRijnhart approved these changes

@Dranyel-Bosd Dranyel-Bosd Dranyel-Bosd approved these changes

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.