[17][MIG] stock_quant_manual_assign #2071

mav-adhoc · 2024-06-12T16:24:44Z

No description provided.

rousseldenis · 2024-06-15T07:36:20Z

/ocabot migration stock_quant_manual_assign

OCA-git-bot · 2024-06-15T07:37:50Z

The migration issue (#1883) has not been updated to reference the current pull request because a previous pull request (#1973) is not closed.
Perhaps you should check that there is no duplicate work.
CC @siemenv

rousseldenis · 2024-06-15T08:03:13Z

@mav-adhoc Could you review #1973 instead ?

mav-adhoc · 2024-06-19T17:24:25Z

@rousseldenis Hi! i can't review a PR in OCA but if you prefer i can close this PR.

rousseldenis · 2024-06-19T17:26:52Z

@mav-adhoc Ok, thanks.

rousseldenis · 2024-07-23T07:17:30Z

@mav-adhoc So, could you fix this ?

* Better layout * Remove active_id dependency in some computed fields * Clean code * Refine constraint * Take into account if the current line is previously reserved before clicking on the button.

… default them

…ds + add security groups + hook

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: stock-logistics-warehouse-13.0/stock-logistics-warehouse-13.0-stock_quant_manual_assign Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-13-0/stock-logistics-warehouse-13-0-stock_quant_manual_assign/

mav-adhoc · 2024-09-03T17:21:26Z

@rousseldenis Suggested changes done! I think the PR is ready to be merged.

yostashiro

Thanks for the updates!

stock_quant_manual_assign/wizard/assign_manual_quants.py

mav-adhoc · 2024-09-04T18:01:07Z

@antoniocanovas Can you review again please? Thanks!

mav-adhoc · 2024-09-10T16:13:33Z

@rousseldenis I think the PR is ready to be merged! If you think i should make another change tell me! Thanks!

mav-adhoc · 2024-09-16T20:17:06Z

@antoniocanovas Hi! Can you review the PR again please? Thanks!

mav-adhoc · 2024-10-16T17:30:06Z

@rousseldenis Hi! Can we merge this PR? Thanks

mav-adhoc · 2024-10-16T17:57:07Z

@tafaRU @sebalix @JordiBForgeFlow @jbaudoux Hi! can someone review this PR please? Thanks!

rousseldenis · 2024-10-17T07:12:05Z

/ocabot migration stock_quant_manual_assign

florenciafrigieri2 · 2024-11-06T17:20:52Z

@rousseldenis Hi! Is it possible to merge this PR?

mav-adhoc · 2024-11-14T16:47:08Z

@rousseldenis @tafaRU @sebalix @JordiBForgeFlow @jbaudoux Hi! Can we merge this PR? We need to migrate this module to 18.0

mav-adhoc · 2024-12-04T17:52:06Z

@rousseldenis Hi! Sorry to bother you! I am just worried why this PR is not moving forward

yostashiro · 2024-12-30T13:06:51Z

@mav-adhoc This PR seems to be missing the following commits. Can you please include them?

9f3eeb2
c7dc47b

LoisRForgeFlow · 2025-01-15T15:23:12Z

@mav-adhoc A friendly reminder here, would you take care of the previous @yostashiro comment?

mav-adhoc · 2025-01-20T13:53:11Z

@yostashiro @LoisRForgeFlow Done!

LoisRForgeFlow · 2025-01-20T13:57:05Z

@mav-adhoc Thanks! could you now check CI? It is failing in one of the tests of this module https://github.com/OCA/stock-logistics-warehouse/actions/runs/12869470900/job/35878347321?pr=2071#step:8:412

yostashiro · 2025-01-20T14:06:19Z

The changes from my commit need to be adjusted (simplified) because of #2071 (comment)...

This commit fixes the following issues: - The previous code does not handle the immediate transfer scenario when auto_fill_qty_done is selected in the operation type. This raises a missing-record error, trying to update qty_done on non-existing move line records. - move._do_unreserve() keeps existing stock.move.line records if there is some qty_done set, which is not a desirable outcome. All the linked move line records should be unlinked before selected quants are assigned.

mav-adhoc · 2025-01-21T11:44:17Z

@yostashiro What do you recommend me to do?

yostashiro · 2025-01-22T02:35:23Z

@AungKoKoLin1997 Can you please help suggest adjustments? I'm a bit tied up.

AungKoKoLin1997 · 2025-01-22T05:05:33Z

stock_quant_manual_assign/wizard/assign_manual_quants.py

+        if move.picking_type_id.auto_fill_qty_done:
+            if move.from_immediate_transfer:
+                move.quantity_done = self.lines_qty
+            else:
+                # Auto-fill all lines as done
+                for ml in move.move_line_ids:
+                    ml.qty_done = ml.reserved_uom_qty


There is no auto_fill_qty_done anymore and the distinction between immediate and planned transfers is eliminated from odoo17. Then, qty done and reserved qty are merged into one column as quantity field.
So, I think we can remove this part.

AungKoKoLin1997 · 2025-01-22T05:14:59Z

stock_quant_manual_assign/tests/test_stock_quant_manual_assign.py

+            2,
+            "There are 2 quants selected",
+        )
+        self.assertEqual(sum(self.move.move_line_ids.mapped("qty_done")), 0.0)


Suggested change

self.assertEqual(sum(self.move.move_line_ids.mapped("qty_done")), 0.0)

self.assertEqual(sum(self.move.move_line_ids.mapped("quantity")), 150.0)

AungKoKoLin1997 · 2025-01-22T05:15:27Z

stock_quant_manual_assign/tests/test_stock_quant_manual_assign.py

+        wizard = self._create_wizard()
+        self._process_basic_manual_assign_steps(wizard)
+        wizard.assign_quants()
+        self.assertEqual(sum(self.move.move_line_ids.mapped("qty_done")), 150.0)


Suggested change

self.assertEqual(sum(self.move.move_line_ids.mapped("qty_done")), 150.0)

self.assertEqual(sum(self.move.move_line_ids.mapped("quantity")), 150.0)

rousseldenis added needs review migration labels Jun 15, 2024

OCA-git-bot added this to the 17.0 milestone Jun 15, 2024

rousseldenis added duplicate and removed needs review labels Jun 15, 2024

rousseldenis closed this Jun 19, 2024

mav-adhoc mentioned this pull request Jul 18, 2024

[17.0][MIG] stock_quant_manual_assign: Migration to 17.0 #1973

Closed

rousseldenis reopened this Jul 23, 2024

fanha99 and others added 16 commits July 23, 2024 09:54

[MIG] stock_quant_manual_assign: Migration to 10.0

7cea61a

11.0-mig-stock_quant_manual_assign

c7b6d99

[MIG] stock_quant_manual_assign: Migration to 11.0

8af3b2d

[IMP] stock_quant_manual_assign:

d46d8b9

* Better layout * Remove active_id dependency in some computed fields * Clean code * Refine constraint * Take into account if the current line is previously reserved before clicking on the button.

[FIX] stock_quant_manual_assign: Related fields are not filled if not…

d93ae0d

… default them

[IMP] stock_quant_manual_assign: Add owner to criteria + reorder fiel…

88d73ad

…ds + add security groups + hook

[UPD] Update stock_quant_manual_assign.pot

c308823

[12.0][MIG] stock_quant_manual_assign

cad0db2

[IMP] stock_quant_manual_assign: black, isort, prettier

2786337

[MIG] stock_quant_manual_assign: Migration to 13.0

38dccd3

[UPD] Update stock_quant_manual_assign.pot

deb0f0b

[UPD] README.rst

ac9f05c

[UPD] Eficent -> ForgeFlow

c57662a

[UPD] README.rst

697a82c

mav-adhoc force-pushed the 17.0-mig-stock_quant_manual_assign branch from c67cdaf to e5b0e65 Compare September 3, 2024 17:17

yostashiro approved these changes Sep 4, 2024

View reviewed changes

stock_quant_manual_assign/wizard/assign_manual_quants.py Show resolved Hide resolved

BT-etejeda approved these changes Sep 4, 2024

View reviewed changes

OCA-git-bot added the approved label Sep 4, 2024

OCA-git-bot mentioned this pull request Oct 17, 2024

Migration to version 17.0 #1883

Open

50 tasks

yostashiro mentioned this pull request Dec 30, 2024

[17.0] [MIG] stock_quant_manual_assign #2226

Closed

MeritxellAForgeFlow mentioned this pull request Jan 9, 2025

[17.0] [MIG] mrp_production_quant_manual_assign OCA/manufacture#1446

Open

[IMP] stock_quant_manual_assign: Improve readme

308003d

mav-adhoc force-pushed the 17.0-mig-stock_quant_manual_assign branch 2 times, most recently from 4f2a3ac to 3707b31 Compare January 20, 2025 17:25

mav-adhoc force-pushed the 17.0-mig-stock_quant_manual_assign branch from 3707b31 to 5a0657a Compare January 20, 2025 17:38

AungKoKoLin1997 reviewed Jan 22, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[17][MIG] stock_quant_manual_assign #2071

[17][MIG] stock_quant_manual_assign #2071

mav-adhoc commented Jun 12, 2024

rousseldenis commented Jun 15, 2024

OCA-git-bot commented Jun 15, 2024

rousseldenis commented Jun 15, 2024

mav-adhoc commented Jun 19, 2024

rousseldenis commented Jun 19, 2024

rousseldenis commented Jul 23, 2024

mav-adhoc commented Sep 3, 2024

yostashiro left a comment

mav-adhoc commented Sep 4, 2024

mav-adhoc commented Sep 10, 2024

mav-adhoc commented Sep 16, 2024

mav-adhoc commented Oct 16, 2024

mav-adhoc commented Oct 16, 2024

rousseldenis commented Oct 17, 2024

florenciafrigieri2 commented Nov 6, 2024

mav-adhoc commented Nov 14, 2024

mav-adhoc commented Dec 4, 2024

yostashiro commented Dec 30, 2024

LoisRForgeFlow commented Jan 15, 2025

mav-adhoc commented Jan 20, 2025

LoisRForgeFlow commented Jan 20, 2025

yostashiro commented Jan 20, 2025

mav-adhoc commented Jan 21, 2025

yostashiro commented Jan 22, 2025

AungKoKoLin1997 Jan 22, 2025

AungKoKoLin1997 Jan 22, 2025

AungKoKoLin1997 Jan 22, 2025

	self.assertEqual(sum(self.move.move_line_ids.mapped("qty_done")), 0.0)
	self.assertEqual(sum(self.move.move_line_ids.mapped("quantity")), 150.0)

[17][MIG] stock_quant_manual_assign #2071

Are you sure you want to change the base?

[17][MIG] stock_quant_manual_assign #2071

Conversation

mav-adhoc commented Jun 12, 2024

rousseldenis commented Jun 15, 2024

OCA-git-bot commented Jun 15, 2024

rousseldenis commented Jun 15, 2024

mav-adhoc commented Jun 19, 2024

rousseldenis commented Jun 19, 2024

rousseldenis commented Jul 23, 2024

mav-adhoc commented Sep 3, 2024

yostashiro left a comment

Choose a reason for hiding this comment

mav-adhoc commented Sep 4, 2024

mav-adhoc commented Sep 10, 2024

mav-adhoc commented Sep 16, 2024

mav-adhoc commented Oct 16, 2024

mav-adhoc commented Oct 16, 2024

rousseldenis commented Oct 17, 2024

florenciafrigieri2 commented Nov 6, 2024

mav-adhoc commented Nov 14, 2024

mav-adhoc commented Dec 4, 2024

yostashiro commented Dec 30, 2024

LoisRForgeFlow commented Jan 15, 2025

mav-adhoc commented Jan 20, 2025

LoisRForgeFlow commented Jan 20, 2025

yostashiro commented Jan 20, 2025

mav-adhoc commented Jan 21, 2025

yostashiro commented Jan 22, 2025

AungKoKoLin1997 Jan 22, 2025

Choose a reason for hiding this comment

AungKoKoLin1997 Jan 22, 2025

Choose a reason for hiding this comment

AungKoKoLin1997 Jan 22, 2025

Choose a reason for hiding this comment