[16.0][FIX] stock_valuation_layer_accounting_date: prevent tests failed for some timezone #2159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AungKoKoLin1997
force-pushed
the
16.0-imp-tests-stock-valuation_layer_accounting_date
branch
from
b7b33fd
to
c1515f9
Compare
yostashiro
suggested changes
Sep 20, 2024
Comment on lines
20
to
22
| @freeze_time("2022-12-02") | ||
| def test_svl_accounting_date_real_time(self): | ||
| self.product1.product_tmpl_id.categ_id.property_valuation = "real_time" |
There was a problem hiding this comment.
We shouldn't be changing the intention of the test.
Suggested change
| @freeze_time("2022-12-02") | |
| def test_svl_accounting_date_real_time(self): | |
| self.product1.product_tmpl_id.categ_id.property_valuation = "real_time" | |
| @freeze_time("2022-12-02 23:00:00") | |
| def test_svl_accounting_date_real_time(self): | |
| self.product1.categ_id.property_valuation = "real_time" | |
| self.env.user.tz = "Asia/Tokyo" |
| def test_svl_accounting_date_real_time(self): | ||
| self.product1.product_tmpl_id.categ_id.property_valuation = "real_time" | ||
| self._make_in_move(self.product1, 10) | ||
| valuation_layer = self.product1.stock_valuation_layer_ids | ||
| self.assertEqual(valuation_layer.accounting_date, date(2022, 12, 3)) | ||
| self.assertEqual(valuation_layer.accounting_date, date(2022, 12, 2)) |
AungKoKoLin1997
force-pushed
the
16.0-imp-tests-stock-valuation_layer_accounting_date
branch
from
c1515f9
to
9fbcafa
Compare
yostashiro
approved these changes
Sep 21, 2024
rousseldenis
approved these changes
Sep 23, 2024
|
This PR has the |
|
@rousseldenis Can we get this PR merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix is to address the issue for failing tests depending on timezone.
Related: #2139 (comment)
ping matt454357
@qrtl