[16.0][FIX] stock_reserve_rule: Don't select negative quants #2229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The conditions to reproduce the problem are:
- A demand of a X quantity
- A positive quant with a big quantity > X (recent)
- A positive quant with a little quantity > X but with all quantities reserved
- A negative quant of a quantity < 0 and abs(quantity) < X
The move reservation should lead to one move line creation
|
@sebalix Issue occurs when quants merge is disabled |
jbaudoux
approved these changes
Jan 9, 2025
jbaudoux
reviewed
Jan 9, 2025
| # Don't take into account those quants as that can lead | ||
| # to a negative demand in the created move line | ||
| # Mimic odoo behavior in move _action_assign() method. | ||
| if location_quantity <= 0: |
There was a problem hiding this comment.
What about using float_compare ?
There was a problem hiding this comment.
I thought about that. I don't know why Odoo does not use it.
https://github.com/odoo/odoo/blob/16.0/addons/stock/models/stock_move.py#L1702
Not only. If quantities are forced, negative quants can occur. |
sebalix
reviewed
Jan 9, 2025
Comment on lines
+806
to
+807
| # Create it without inventory mode as it could merge it with the other one | ||
| self.env["stock.quant"].with_context(inventory_mode=True).create( |
There was a problem hiding this comment.
It says it creates a quant without inventory mode while setting inventory_mode=True in the context?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The conditions to reproduce the problem are:
- A demand of a X quantity
- A positive quant (old) with a big quantity > X
- A positive quant with a little quantity > X but with all quantities reserved
- A negative quant (recent) of a quantity < 0 and abs(quantity) < X
The move reservation should lead to one move line creation