[16.0][MIG] web_widget_json_graph: Migration to 16.0 #2476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…CA#1733) This module allows to load a line graph per ordered pair from an One2many or Many2many field. Co-Authored-By: Francisco Luna <[email protected]> Co-Authored-By: José Robles <[email protected]> Co-Authored-By: Luis González <[email protected]> Co-Authored-By: Nhomar Hernández <[email protected]> Co-authored-by: Francisco Luna <[email protected]> Co-authored-by: José Robles <[email protected]> Co-authored-by: Nhomar Hernández <[email protected]>
|
/ocabot migration web_widget_json_graph Please check pre-commit. You can install it locally for avoiding that problem. |
|
The error is due to: If you are writing new-style JS, your file should be renamed to .esm.js. |
|
I've disabled es-lint for the following line in web_widget_json_graph.esm.js : Chart is loaded by onWillStart(() => loadJS("/web/static/lib/Chart/Chart.js")); but es-lint does'nt seems to recognize it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The js file was rewrited with the new javascript module templates