-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0][MIG] web_refresher: Migration to 18.0 #3001
base: 18.0
Are you sure you want to change the base?
Conversation
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: web-16.0/web-16.0-web_refresher Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_refresher/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: web-16.0/web-16.0-web_refresher Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_refresher/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: web-16.0/web-16.0-web_refresher Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_refresher/
Currently translated at 100.0% (2 of 2 strings) Translation: web-16.0/web-16.0-web_refresher Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_refresher/hr/
Currently translated at 100.0% (2 of 2 strings) Translation: web-16.0/web-16.0-web_refresher Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_refresher/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: web-16.0/web-16.0-web_refresher Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_refresher/
Currently translated at 50.0% (1 of 2 strings) Translation: web-16.0/web-16.0-web_refresher Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_refresher/fr/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: web-17.0/web-17.0-web_refresher Translate-URL: https://translation.odoo-community.org/projects/web-17-0/web-17-0-web_refresher/
Currently translated at 100.0% (2 of 2 strings) Translation: web-17.0/web-17.0-web_refresher Translate-URL: https://translation.odoo-community.org/projects/web-17-0/web-17-0-web_refresher/it/
Currently translated at 100.0% (2 of 2 strings) Translation: web-17.0/web-17.0-web_refresher Translate-URL: https://translation.odoo-community.org/projects/web-17-0/web-17-0-web_refresher/es/
… the main By doing this, the extension view is charged just after the main, so if some other views are using this other, to make a primary one, like project is doing for project.task control_panel, the refresher will continue be shown.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for migrating this usefull module.
Functional review. LGTM.
Please could you fix pre-commit errors ?
Thanks !
[IMP] web_refresher: fix pre-commit errors
db2ee2e
to
2688fe2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be done in a general commit to the repo IMO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And why it's needed? If it's something required, it should be reflected on the template.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And why it's needed? If it's something required, it should be reflected on the template.
This was done to remove pre-commit errors such as “setTimeout” is undefined. Can you please clarify about the template?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The template is in https://github.com/OCA/oca-addons-repo-template/ (through copier)
No description provided.