Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][FIX] web_timeline: Enable XSS protection #3092

Open
wants to merge 1 commit into
base: 17.0
Choose a base branch
from

Conversation

etobella
Copy link
Member

XSS protection was disabled on this widget. It shouldn't happen.... vis-timeline was complaining about it...

A warning was raised:

You disabled XSS protection for vis-Timeline. I sure hope you know what you\'re doing!

@OCA-git-bot
Copy link
Contributor

Hi @tarteo,
some modules you are maintaining are being modified, check this out!

@pedrobaeza pedrobaeza changed the title [FIX] web_timeline: Enable XSS protection [17.0][FIX] web_timeline: Enable XSS protection Feb 17, 2025
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was deactivated in e3e9b5d

It's mentioned that the CSS are not loaded. Is this still happening?

@etobella
Copy link
Member Author

I had the same view when using it and without using it 🤔

I don't know, but warnings were raised for this reason

@pedrobaeza
Copy link
Member

Can you please try this modification using project_timeline_hr_timesheet? The problem was <div t-attf-class="o_project_timeline_hr_timesheet_progress"> didn't show that class, and the same for t-attf-class="text-white {{ record.remaining_hours &lt; 0 ? 'bg-danger ' : 'bg-success '}}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants