Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][IMP] web_widget_x2many_2d_matrix: handle field's widget properly (which support m2m field as a field_value) and fix to prevent errors and update readme usage #3117

Open
wants to merge 4 commits into
base: 17.0
Choose a base branch
from

Conversation

cuongnmtm
Copy link
Contributor

@cuongnmtm cuongnmtm commented Mar 8, 2025

Handle field's widget properly (which support m2m field as a field_value) and fix to prevent errors and update readme usage (#3116)

image

@OCA-git-bot
Copy link
Contributor

Hi @JasminSForgeFlow,
some modules you are maintaining are being modified, check this out!

@cuongnmtm cuongnmtm changed the title [IMP] web_widget_x2many_2d_matrix: handle field's widget properly (wh… [17.0][IMP] web_widget_x2many_2d_matrix: handle field's widget properly (wh… Mar 8, 2025
@cuongnmtm cuongnmtm changed the title [17.0][IMP] web_widget_x2many_2d_matrix: handle field's widget properly (wh… [17.0][IMP] web_widget_x2many_2d_matrix: handle field's widget properly (which support m2m field as a field_value) Mar 8, 2025
@cuongnmtm cuongnmtm force-pushed the 17.0-imp-handle-field-widget-which-support-m2m-as-value branch 3 times, most recently from bd8a63a to 39acdf4 Compare March 8, 2025 19:34
@JasminSForgeFlow
Copy link
Contributor

@cuongnmtm please solve conflicts and create one PR only with all fixes

@cuongnmtm cuongnmtm changed the title [17.0][IMP] web_widget_x2many_2d_matrix: handle field's widget properly (which support m2m field as a field_value) [17.0][IMP] web_widget_x2many_2d_matrix: handle field's widget properly (which support m2m field as a field_value) and fix to prevent errors and update readme usage Mar 19, 2025
@cuongnmtm cuongnmtm force-pushed the 17.0-imp-handle-field-widget-which-support-m2m-as-value branch from 39acdf4 to 83628ee Compare March 19, 2025 03:52
@cuongnmtm
Copy link
Contributor Author

@cuongnmtm please solve conflicts and create one PR only with all fixes

Solved conflicts, this PR contains all the fixes.

Copy link
Contributor

@JasminSForgeFlow JasminSForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UncaughtPromiseError > OwlError
Uncaught Promise > Invalid props for component 'X2ManyField': unknown key 'canCreate', unknown key 'canOpen', unknown key 'canWrite', unknown key 'canQuickCreate', unknown key 'canCreateEdit', 'context' is missing (should be a object)
OwlError: Invalid props for component 'X2ManyField': unknown key 'canCreate', unknown key 'canOpen', unknown key 'canWrite', unknown key 'canQuickCreate', unknown key 'canCreateEdit', 'context' is missing (should be a object)
    Error: Invalid props for component 'X2ManyField': unknown key 'canCreate', unknown key 'canOpen', unknown key 'canWrite', unknown key 'canQuickCreate', unknown key 'canCreateEdit', 'context' is missing (should be a object)
        at Object.validateProps (http://localhost:17001/web/assets/debug/web.assets_web.js:10744:19) (/web/static/lib/owl/owl.js:3160)
        at X2Many2DMatrixRenderer.template (eval at compile (http://localhost:17001/web/assets/debug/web.assets_web.js:13283:20), <anonymous>:61:21) (/web/static/lib/owl/owl.js:5699)
        at Fiber._render (http://localhost:17001/web/assets/debug/web.assets_web.js:9313:38) (/web/static/lib/owl/owl.js:1729)
        at Fiber.render (http://localhost:17001/web/assets/debug/web.assets_web.js:9305:18) (/web/static/lib/owl/owl.js:1721)
        at ComponentNode.initiateRender (http://localhost:17001/web/assets/debug/web.assets_web.js:9985:23) (/web/static/lib/owl/owl.js:2401)

It seems some conflicts with latest changes.
Can you please check?

@katyukha
Copy link

UncaughtPromiseError > OwlError
Uncaught Promise > Invalid props for component 'X2ManyField': unknown key 'canCreate', unknown key 'canOpen', unknown key 'canWrite', unknown key 'canQuickCreate', unknown key 'canCreateEdit', 'context' is missing (should be a object)
OwlError: Invalid props for component 'X2ManyField': unknown key 'canCreate', unknown key 'canOpen', unknown key 'canWrite', unknown key 'canQuickCreate', unknown key 'canCreateEdit', 'context' is missing (should be a object)
    Error: Invalid props for component 'X2ManyField': unknown key 'canCreate', unknown key 'canOpen', unknown key 'canWrite', unknown key 'canQuickCreate', unknown key 'canCreateEdit', 'context' is missing (should be a object)
        at Object.validateProps (http://localhost:17001/web/assets/debug/web.assets_web.js:10744:19) (/web/static/lib/owl/owl.js:3160)
        at X2Many2DMatrixRenderer.template (eval at compile (http://localhost:17001/web/assets/debug/web.assets_web.js:13283:20), <anonymous>:61:21) (/web/static/lib/owl/owl.js:5699)
        at Fiber._render (http://localhost:17001/web/assets/debug/web.assets_web.js:9313:38) (/web/static/lib/owl/owl.js:1729)
        at Fiber.render (http://localhost:17001/web/assets/debug/web.assets_web.js:9305:18) (/web/static/lib/owl/owl.js:1721)
        at ComponentNode.initiateRender (http://localhost:17001/web/assets/debug/web.assets_web.js:9985:23) (/web/static/lib/owl/owl.js:2401)

It seems some conflicts with latest changes. Can you please check?

It seems that this happens only in debug mode. In normal mode it seems that everything works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants