[IMP] web_widget_dropdown_dynamic: Remove QUnit import from tests #3145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasminSForgeFlow
force-pushed
the
18.0-imp-web_widget_dropdown_dynamic
branch
from
03583c0 to
17cc86c
Compare
JasminSForgeFlow
force-pushed
the
18.0-imp-web_widget_dropdown_dynamic
branch
from
fb4588a to
6d444f5
Compare
JordiMForgeFlow
approved these changes
Apr 1, 2025
MeritxellAForgeFlow
approved these changes
Apr 1, 2025
| import {editInput, getFixture} from "@web/../tests/helpers/utils"; | ||
| import {makeView, setupViewRegistries} from "@web/../tests/views/helpers"; | ||
| import {QUnit} from "@web/static/lib/qunit/qunit"; |
There was a problem hiding this comment.
Isn't it QUnit used a bit below? Could you explain the rationale behind the patch?
There was a problem hiding this comment.
It doesn't require import as it's js lib
and causing this issue in web_timeline tests
2025-04-01 07:14:55,423 270 ERROR odoo odoo.addons.web_timeline.tests.test_web_timeline.TestWebTimeline.test_timeline_arch.browser: The following modules are needed by other modules but have not been defined, they may not be present in the correct asset bundle: ['@web/static/lib/qunit/qunit']
|
This PR has the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix tests issue in #3136