-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Database outputs #5
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! In addition to the thing about locally storing the CODAB, I think we just need to add a line to run pipelines/update_database.py
to the workflow .yml
so this runs each day as well.
Then, as discussed, we can do a separate PR to bypass the intermediate .parquet
storage and just write straight to the DB. But we can merge this one first to get the DB write happening automatically each day, cause I noticed it's getting out of date in the app.
@t-downing I've addressed the database issues here and repopulated the
I think we'll want to work on the migration from parquet and the daily updates together. Rerunning this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can merge this now as an intermediate step to switching to the new database table
Porting over code from https://github.com/OCHA-DAP/ds-floodexposure-monitoring-app, that should live as a pipeline instead. This is a quick and dirty copy and paste exercise -- there are still a number of things that we'll need to improve to make this our production pipeline. .