Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a README in nuspec #1377

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add a README in nuspec #1377

wants to merge 3 commits into from

Conversation

WanjohiSammy
Copy link
Contributor

@WanjohiSammy WanjohiSammy commented Dec 18, 2024

Issues

This pull request fixes #xxx.

Description

This PR

  • update README file
  • update nuspec files to add readme element. This is to ensure README.md is package when generating NuGet package.

README.md file updated:

Checklist (Uncheck if it is not completed)

  • Test cases added
  • Build and test with one-click build and test script passed

Additional work necessary

If documentation update is needed, please add "Docs Needed" label to the issue and provide details about the required document change in the issue.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 4 changed files in this pull request and generated no comments.

Files not reviewed (3)
  • src/Microsoft.AspNetCore.OData.Nightly.nuspec: Language not supported
  • src/Microsoft.AspNetCore.OData.Release.nuspec: Language not supported
  • src/Microsoft.AspNetCore.OData/Microsoft.AspNetCore.OData.csproj: Language not supported
@WanjohiSammy WanjohiSammy changed the title Add readme path from cproj and add it in nuspec Add a README in nuspec Dec 18, 2024
xuzhg
xuzhg previously approved these changes Dec 19, 2024
@WanjohiSammy WanjohiSammy requested review from Copilot and xuzhg January 2, 2025 11:45

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 4 changed files in this pull request and generated no comments.

Files not reviewed (3)
  • src/Microsoft.AspNetCore.OData.Nightly.nuspec: Language not supported
  • src/Microsoft.AspNetCore.OData.Release.nuspec: Language not supported
  • src/Microsoft.AspNetCore.OData/Microsoft.AspNetCore.OData.csproj: Language not supported
Comments suppressed due to low confidence (2)

README.md:1

  • The title should be 'ASP.NET Core OData 8.x' to maintain consistency with the previous version.
# ASP.NET Core OData

README.md:91

  • The GetEdmModel function should include the Product entity type to be consistent with the example provided.
builder.EntityType<Order>();
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants